Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

fuzzed file timeout

Browse Source 
objcopy of archive, element containing an object with a fuzzed section
size far exceeding the element size.  copy_section detects this, but
the temp file is laid out for the large section.  It can take a long
time to write terabytes of sparse file, a waste of time when it will
be deleted.

	* objcopy.c (copy_archive): Don't write element contents after
	bad status result from copy_object.
This commit is contained in:
Alan Modra
2023-01-04 21:46:06 +10:30
parent c093f5eeab
commit 3bba9d9329
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
binutils/objcopy.c
View File

@@ -3686,7 +3686,8 @@ copy_archive (bfd *ibfd, bfd *obfd, const char *output_target,
if (!ok_object)
del = !copy_unknown_object (this_element, output_bfd);
if (!(ok_object && !del ? bfd_close : bfd_close_all_done) (output_bfd))
if (!(ok_object && !del && !status
? bfd_close : bfd_close_all_done) (output_bfd))
{
bfd_nonfatal_message (output_name, NULL, NULL, NULL);
/* Error in new object file. Don't change archive. */