Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Add a new gdbarch method to fetch signal information from core files.

Browse Source 
Previously the core_xfer_partial method used core_get_siginfo to handle
TARGET_OBJECT_SIGNAL_INFO requests.  However, core_get_siginfo looked for
Linux-specific sections in the core file.  To support fetching siginfo
from cores on other systems, add a new gdbarch method (`core_xfer_siginfo`)
and move the body of the existing core_get_siginfo into a
linux_core_xfer_siginfo implementation of this method in linux-tdep.c.

gdb/ChangeLog:

	* corelow.c (get_core_siginfo): Remove.
	(core_xfer_partial): Use the gdbarch "core_xfer_siginfo" method
	instead of get_core_siginfo.
	* gdbarch.sh (core_xfer_siginfo): New gdbarch callback.
	* gdbarch.h: Re-generate.
	* gdbarch.c: Re-generate.
	* linux-tdep.c (linux_core_xfer_siginfo): New.
	(linux_init_abi): Install gdbarch "core_xfer_siginfo" method.
This commit is contained in:
John Baldwin
2017-06-28 11:11:20 -07:00
parent 6e5eab33ab
commit 382b69bbb7
6 changed files with 92 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
gdb/corelow.c
View File

@@ -668,25 +668,6 @@ add_to_spuid_list (bfd *abfd, asection *asect, void *list_p)
list->pos += 4;
}
/* Read siginfo data from the core, if possible. Returns -1 on
failure. Otherwise, returns the number of bytes read. ABFD is the
core file's BFD; READBUF, OFFSET, and LEN are all as specified by
the to_xfer_partial interface. */
static LONGEST
get_core_siginfo (bfd *abfd, gdb_byte *readbuf, ULONGEST offset, ULONGEST len)
{
thread_section_name section_name (".note.linuxcore.siginfo", inferior_ptid);
asection *section = bfd_get_section_by_name (abfd, section_name.c_str ());
if (section == NULL)
return -1;
if (!bfd_get_section_contents (abfd, section, readbuf, offset, len))
return -1;
return len;
}
static enum target_xfer_status
core_xfer_partial (struct target_ops *ops, enum target_object object,
const char *annex, gdb_byte *readbuf,
@@ -874,12 +855,20 @@ core_xfer_partial (struct target_ops *ops, enum target_object object,
case TARGET_OBJECT_SIGNAL_INFO:
if (readbuf)
{
LONGEST l = get_core_siginfo (core_bfd, readbuf, offset, len);
if (l > 0)
if (core_gdbarch
&& gdbarch_core_xfer_siginfo_p (core_gdbarch))
{
*xfered_len = len;
return TARGET_XFER_OK;
LONGEST l = gdbarch_core_xfer_siginfo (core_gdbarch, readbuf,
offset, len);
if (l >= 0)
{
*xfered_len = l;
if (l == 0)
return TARGET_XFER_EOF;
else
return TARGET_XFER_OK;
}
}
}
return TARGET_XFER_E_IO;