Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

libctf: strings: don't check for non-deduplicable atoms in the parent

Browse Source 
Callers of ctf_str_add_no_dedup_ref are indicating that they would like the
string they have added a reference to to appear in the current dict and not
be deduplicated into the parent.  This is true even if the string already
exists in the parent, so we should not check for strings in the parent and
reuse them in this case.
This commit is contained in:
Nick Alcock
2025-04-25 18:17:33 +01:00
parent 3520fb4568
commit 343de78445
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libctf/ctf-string.c
View File

@@ -313,11 +313,12 @@ ctf_str_add_ref_internal (ctf_dict_t *fp, const char *str,
int added = 0;
ctf_dict_t *lookup_fp = fp;
/* Check for existing atoms in the parent as well. */
/* Check for existing atoms in the parent as well, unless they are marked
non-deduplicable. */
atom = ctf_dynhash_lookup (fp->ctf_str_atoms, str);
if (!atom && fp->ctf_parent)
if (!atom && fp->ctf_parent && !(flags & CTF_STR_NO_DEDUP))
{
lookup_fp = fp->ctf_parent;
atom = ctf_dynhash_lookup (lookup_fp->ctf_str_atoms, str);