Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

gdb: create_breakpoint: add asserts and additional comments

Browse Source 
This commit extends the asserts on create_breakpoint (in the header
file), and adds some additional assertions into the definition.

The new assert confirms that when the thread and inferior information
is going to be parsed from the extra_string, then the thread and
inferior arguments should be -1.  That is, the caller of
create_breakpoint should not try to create a thread/inferior specific
breakpoint by *both* specifying thread/inferior *and* asking to parse
the extra_string, it's one or the other.

There should be no user visible changes after this commit.
This commit is contained in:
Andrew Burgess
2023-03-15 16:06:30 +00:00
parent daeda14191
commit 32f5a9896d
2 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/breakpoint.c
View File

@@ -9220,6 +9220,12 @@ create_breakpoint (struct gdbarch *gdbarch,
gdb_assert (inferior == -1 || inferior > 0);
gdb_assert (thread == -1 || inferior == -1);
/* If PARSE_EXTRA is true then the thread and inferior details will be
parsed from the EXTRA_STRING, the THREAD and INFERIOR arguments
should be -1. */
gdb_assert (!parse_extra || thread == -1);
gdb_assert (!parse_extra || inferior == -1);
gdb_assert (ops != NULL);
/* If extra_string isn't useful, set it to NULL. */