Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Remove some is_mi_like_p from breakpoint code

Browse Source 
This removes some uses of is_mi_like_p from the breakpoint code.  The
break-catch-throw.c change brings it into line with what other
breakpoint classes do.  The other changes simply replace printf calls
with ui_out::text or ui_out::message calls.

ChangeLog
2018-04-30  Tom Tromey  <tom@tromey.com>

	* breakpoint.c (mention): Remove use of is_mi_like_p.
	(print_mention_ranged_breakpoint): Likewise.
	* break-catch-throw.c (print_it_exception_catchpoint): Remove use
	of is_mi_like_p.
This commit is contained in:
Tom Tromey
2018-04-29 20:52:26 -06:00
parent f3c6ababac
commit 2d33446d4d
3 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@@ -1,3 +1,10 @@
2018-04-30 Tom Tromey <tom@tromey.com>
* breakpoint.c (mention): Remove use of is_mi_like_p.
(print_mention_ranged_breakpoint): Likewise.
* break-catch-throw.c (print_it_exception_catchpoint): Remove use
of is_mi_like_p.
2018-04-30 Tom Tromey <tom@tromey.com> 2018-04-30 Tom Tromey <tom@tromey.com>
* tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p. * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.

4
gdb/break-catch-throw.c
View File

@@ -238,8 +238,7 @@ print_it_exception_catchpoint (bpstat bs)
bp_temp = b->disposition == disp_del; bp_temp = b->disposition == disp_del;
uiout->text (bp_temp ? "Temporary catchpoint " uiout->text (bp_temp ? "Temporary catchpoint "
: "Catchpoint "); : "Catchpoint ");
if (!uiout->is_mi_like_p ()) uiout->field_int ("bkptno", b->number);
uiout->field_int ("bkptno", b->number);
uiout->text ((kind == EX_EVENT_THROW ? " (exception thrown), " uiout->text ((kind == EX_EVENT_THROW ? " (exception thrown), "
: (kind == EX_EVENT_CATCH ? " (exception caught), " : (kind == EX_EVENT_CATCH ? " (exception caught), "
: " (exception rethrown), "))); : " (exception rethrown), ")));
@@ -248,7 +247,6 @@ print_it_exception_catchpoint (bpstat bs)
uiout->field_string ("reason", uiout->field_string ("reason",
async_reason_lookup (EXEC_ASYNC_BREAKPOINT_HIT)); async_reason_lookup (EXEC_ASYNC_BREAKPOINT_HIT));
uiout->field_string ("disp", bpdisp_text (b->disposition)); uiout->field_string ("disp", bpdisp_text (b->disposition));
uiout->field_int ("bkptno", b->number);
} }
return PRINT_SRC_AND_LOC; return PRINT_SRC_AND_LOC;
} }

13
gdb/breakpoint.c
View File

@@ -8596,9 +8596,7 @@ static void
mention (struct breakpoint *b) mention (struct breakpoint *b)
{ {
b->ops->print_mention (b); b->ops->print_mention (b);
if (current_uiout->is_mi_like_p ()) current_uiout->text ("\n");
return;
printf_filtered ("\n");
} }
@@ -9795,12 +9793,9 @@ print_mention_ranged_breakpoint (struct breakpoint *b)
gdb_assert (bl); gdb_assert (bl);
gdb_assert (b->type == bp_hardware_breakpoint); gdb_assert (b->type == bp_hardware_breakpoint);
if (uiout->is_mi_like_p ()) uiout->message (_("Hardware assisted ranged breakpoint %d from %s to %s."),
return; b->number, paddress (bl->gdbarch, bl->address),
paddress (bl->gdbarch, bl->address + bl->length - 1));
printf_filtered (_("Hardware assisted ranged breakpoint %d from %s to %s."),
b->number, paddress (bl->gdbarch, bl->address),
paddress (bl->gdbarch, bl->address + bl->length - 1));
} }
/* Implement the "print_recreate" breakpoint_ops method for /* Implement the "print_recreate" breakpoint_ops method for