Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

gdb: make target_close check that the target isn't pushed in all inferiors

Browse Source 
The target_close function currently checks that the target to be closed
isn't pushed in the current inferior:

    gdb_assert (!current_inferior ()->target_is_pushed (targ));

Normally, a target is closed when its refcount has dropped to 0, due to
not being used in any inferior anymore.  I think it would make sense to
change that assert to not only check in the current inferior, but to
check in all inferiors.  It would be quite bad (and a bug) to close a
target while it's still pushed in one of the non-current inferiors.

gdb/ChangeLog:

	* target.c (target_close): Check in all inferiors that the
	target is not pushed.

Change-Id: I6e37fc3f3476a0593da1e476604642b2de90f1d5
This commit is contained in:
Simon Marchi
2021-05-07 11:51:19 -04:00
committed by Simon Marchi
parent 1d1669e40f
commit 27f0a4314a
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@@ -1,3 +1,8 @@
2021-05-07 Simon Marchi <simon.marchi@efficios.com>
* target.c (target_close): Check in all inferiors that the
target is not pushed.
2021-05-07 Aaron Merey <amerey@redhat.com>
* debuginfod-support.c (debuginfod_init): Remove.

3
gdb/target.c
View File

@@ -3734,7 +3734,8 @@ debug_target::info () const
void
target_close (struct target_ops *targ)
{
gdb_assert (!current_inferior ()->target_is_pushed (targ));
for (inferior *inf : all_inferiors ())
gdb_assert (!inf->target_is_pushed (targ));
fileio_handles_invalidate_target (targ);