Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

gdb/

Browse Source 
Fix double free on error inserting the breakpoint instruction.
	* breakpoint.c (create_breakpoints): Move the
	update_global_location_list call to ...
	(break_command_really): ... here together with the second local call
	both unified after all the cleanups.
This commit is contained in:
Jan Kratochvil
2009-04-23 22:38:24 +00:00
parent b14b1491f2
commit 217dc9e25b
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/breakpoint.c
View File

@@ -5458,8 +5458,6 @@ create_breakpoints (struct symtabs_and_lines sals, char **addr_string,
cond_string, type, disposition,
thread, task, ignore_count, ops, from_tty, enabled);
}
update_global_location_list (1);
}
/* Parse ARG which is assumed to be a SAL specification possibly
@@ -5800,7 +5798,6 @@ break_command_really (char *arg, char *cond_string, int thread,
b->ops = ops;
b->enable_state = enabled ? bp_enabled : bp_disabled;
update_global_location_list (1);
mention (b);
}
@@ -5812,6 +5809,9 @@ break_command_really (char *arg, char *cond_string, int thread,
discard_cleanups (breakpoint_chain);
/* But cleanup everything else. */
do_cleanups (old_chain);
/* error call may happen here - have BREAKPOINT_CHAIN already discarded. */
update_global_location_list (1);
}
/* Set a breakpoint.