Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Prevent the linker from overestimating the alignment requirement of common symbols on targets with octets that are larger than one byte.

Browse Source 
PR 26543
	* linker.c (bfd_generic_define_common_symbol): Force the alignment
	to 1 if the section has now alignment requirement.
This commit is contained in:
Tuckker
2020-08-28 13:27:16 +01:00
committed by Nick Clifton
parent 626d23209f
commit 1e597a8997
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
bfd/linker.c
View File

@@ -3095,8 +3095,13 @@ bfd_generic_define_common_symbol (bfd *output_bfd,
section = h->u.c.p->section;
/* Increase the size of the section to align the common symbol.
The alignment must be a power of two. */
alignment = bfd_octets_per_byte (output_bfd, section) << power_of_two;
The alignment must be a power of two. But if the section does
not have any alignment requirement then do not increase the
alignment unnecessarily. */
if (power_of_two)
alignment = bfd_octets_per_byte (output_bfd, section) << power_of_two;
else
alignment = 1;
BFD_ASSERT (alignment != 0 && (alignment & -alignment) == alignment);
section->size += alignment - 1;
section->size &= -alignment;