Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

make_corefile_notes: have caller free returned memory

Browse Source 
The various make_corefile_notes implementations for gdbarch as well as target
currently make an xfree cleanup on the data they return.  This causes problems
when trying to put a TRY_CATCH around the make_corefile_notes call.
Specifically, we get a stale cleanup error in restore_my_cleanups.

Omit the make_cleanup and have the caller free the memory.

gdb/
	* fbsd-nat.c (fbsd_make_corefile_notes): Remove make_cleanup call.
	* gcore.c (write_gcore_file): Free memory returned from
	make_corefile_notes.
	* linux-tdep.c (linux_make_corefile_notes): Remove make_cleanup call.
	* procfs.c (procfs_make_note_section): Remove make_cleanup call.
This commit is contained in:
Markus Metzger
2014-05-22 08:47:42 +02:00
parent 31f0c4c1c6
commit 1d1f1ccb33
5 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/gcore.c
View File

@@ -68,6 +68,7 @@ create_gcore_bfd (const char *filename)
void
write_gcore_file (bfd *obfd)
{
struct cleanup *cleanup;
void *note_data = NULL;
int note_size = 0;
asection *note_sec = NULL;
@@ -81,6 +82,8 @@ write_gcore_file (bfd *obfd)
else
note_data = gdbarch_make_corefile_notes (target_gdbarch (), obfd, &note_size);
cleanup = make_cleanup (xfree, note_data);
if (note_data == NULL || note_size == 0)
error (_("Target does not support core file generation."));
@@ -104,6 +107,8 @@ write_gcore_file (bfd *obfd)
/* Write out the contents of the note section. */
if (!bfd_set_section_contents (obfd, note_sec, note_data, 0, note_size))
warning (_("writing note section (%s)"), bfd_errmsg (bfd_get_error ()));
do_cleanups (cleanup);
}
static void