Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Print bfloat16 DWARF types correctly

Browse Source 
Even if the DWARF information contains a bfloat16 base type (__bf16), a
variable of such type will still be printed using the IEEE half float format,
which is wrong.

This patch teaches GDB how to pick the bfloat16 format for __bf16 types in
DWARF (based on the base type name) and uses IEEE half float for all the other
16-bit float formats.

Tested on aarch64-linux/x86_64-linux.

OK?

gdb/ChangeLog:

2021-04-16  Luis Machado  <luis.machado@linaro.org>

	* arch-utils.c (default_floatformat_for_type): Handle bfloat16.

gdb/testsuite:

2021-04-16  Luis Machado  <luis.machado@linaro.org>

	* gdb.dwarf2/dw2-bfloat16.exp: New file.
This commit is contained in:
Luis Machado
2021-04-14 11:20:18 -03:00
parent 6f8f6017a0
commit 1b6b755e91
4 changed files with 97 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/arch-utils.c
View File

@@ -279,7 +279,13 @@ default_floatformat_for_type (struct gdbarch *gdbarch,
{
const struct floatformat **format = NULL;
if (len == gdbarch_half_bit (gdbarch))
/* Check if this is a bfloat16 type. It has the same size as the
IEEE half float type, so we use the base type name to tell them
apart. */
if (name != nullptr && strcmp (name, "__bf16") == 0
&& len == gdbarch_bfloat16_bit (gdbarch))
format = gdbarch_bfloat16_format (gdbarch);
else if (len == gdbarch_half_bit (gdbarch))
format = gdbarch_half_format (gdbarch);
else if (len == gdbarch_float_bit (gdbarch))
format = gdbarch_float_format (gdbarch);