Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

PR28448, Memory leak in function add_symbols(plugin.c)

Browse Source 
PR 28448
	* plugin.c (add_symbols): bfd_alloc memory for symptrs.  Check
	bfd_make_empty_symbol return.
This commit is contained in:
Alan Modra
2024-02-15 16:55:59 +10:30
parent 313f04b6ed
commit 19bfbfa665
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ld/plugin.c
View File

@@ -506,7 +506,9 @@ add_symbols (void *handle, int nsyms, const struct ld_plugin_symbol *syms)
int n;
ASSERT (called_plugin);
symptrs = xmalloc (nsyms * sizeof *symptrs);
symptrs = bfd_alloc (abfd, nsyms * sizeof *symptrs);
if (symptrs == NULL)
return LDPS_ERR;
for (n = 0; n < nsyms; n++)
{
enum ld_plugin_status rv;
@@ -514,6 +516,8 @@ add_symbols (void *handle, int nsyms, const struct ld_plugin_symbol *syms)
bfdsym = bfd_make_empty_symbol (abfd);
symptrs[n] = bfdsym;
if (bfdsym == NULL)
return LDPS_ERR;
rv = asymbol_from_plugin_symbol (abfd, bfdsym, syms + n);
if (rv != LDPS_OK)
return rv;