Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Do not crash when calling GDB with empty executable name.

Browse Source 
% gdb -q ''

... or ...

        % gdb -q
        (gdb) file ''

... both cause GDB to crash with an invalid free. This is because
exec_file_attach is attempting to free a string that has not been
allocated. The string is only allocated if openp is successful.
But in the case of this obviously invalid filename, openp fails,
and leaves scratch_pathname uninitialized, thus causing the xfree
to fail.

The fix is to enable the associated cleanup after we have verified
that openp was successful.

gdb/ChangeLog (By Keith Seitz  <keiths@redhat.com>):

        * exec.c (exec_file_attach): Move cleanup after verifying that
        memory has in fact been allocated.

gdb/testsuite/ChangeLog:

        * gdb.base/empty_exe.exp: New testcase.
This commit is contained in:
Joel Brobecker
2012-11-26 17:41:44 +00:00
parent 210bbc17ac
commit 17d6efc44b
4 changed files with 37 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/exec.c
View File

@@ -225,11 +225,11 @@ exec_file_attach (char *filename, int from_tty)
&scratch_pathname);
}
#endif
if (scratch_chan < 0)
perror_with_name (filename);
cleanups = make_cleanup (xfree, scratch_pathname);
if (scratch_chan < 0)
perror_with_name (filename);
if (write_files)
exec_bfd = gdb_bfd_fopen (scratch_pathname, gnutarget,
FOPEN_RUB, scratch_chan);