Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

ld: Track changes to default region LMA even for empty sections

Browse Source 
Given a linker script fragment like this:

   SECTIONS {
     . = 0x1000;
     .text   : AT(0x100) { *(.text)   }
     .data   : AT(0x200) { *(.data)   }
     .rodata : AT(0x300) { *(.rodata) }
   }

and an input file containing sections, '.text', '.data.1', and
'.rodata', then we'd expect the linker to place '.text' and '.rodata' in
the obvious way, and the '.data.1' orphan section would be located after
the '.data' section (assuming similar section properties).

Further, I believe that the expectation would be that the LMA for the
orphan '.data.1' section would start from 0x200 (as there is no '.data'
content).

However, right now, the LMA for '.data.1' would be 0x101, following on
from the '.text' section, this is because the change in LMA for the
'.data' section is not noticed by the linker, if there's no content in
the '.data' section.

What can be even more confusing to a user (though the cause is obvious
once you understand what's going on) is that adding some content to
'.data' will cause the orphan '.data.1' to switch to an LMA based off of
0x200.

This commit changes the behaviour so that an empty section that is in
the default lma region, and sets its lma, will adjust the lma of the
default region, this change will then be reflected in following sections
within the default lma memory region.

There's a new test to cover this issue that passes on a range of
targets, however, some targets generate additional sections, or have
stricter memory region size requirements that make it harder to come
up with a generic pass pattern, that still tests the required
features.  For now I've set the test to ignore these targets.

ld/ChangeLog:

	* ldlang.c (lang_size_sections_1): Shortcut loop only after
	tracking changes to the default regions LMA.
	* testsuite/ld-elf/orphan-9.ld: Extend header comment.
	* testsuite/ld-elf/orphan-10.d: New file.
	* testsuite/ld-elf/orphan-10.s: New file.
	* NEWS: Mention change in behaviour.
This commit is contained in:
Andrew Burgess
2017-01-17 19:13:29 +00:00
parent 77f5e65ecf
commit 14ea2c1b23
6 changed files with 47 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
ld/ldlang.c
View File

@@ -5197,9 +5197,6 @@ lang_size_sections_1
}
os->processed_lma = TRUE;
if (bfd_is_abs_section (os->bfd_section) || os->ignored)
break;
/* Keep track of normal sections using the default
lma region. We use this to set the lma for
following sections. Overlays or other linker
@@ -5207,7 +5204,13 @@ lang_size_sections_1
default lma == vma is incorrect.
To avoid warnings about dot moving backwards when using
-Ttext, don't start tracking sections until we find one
of non-zero size or with lma set differently to vma. */
of non-zero size or with lma set differently to vma.
Do this tracking before we short-cut the loop so that we
track changes for the case where the section size is zero,
but the lma is set differently to the vma. This is
important, if an orphan section is placed after an
otherwise empty output section that has an explicit lma
set, we want that lma reflected in the orphans lma. */
if (!IGNORE_SECTION (os->bfd_section)
&& (os->bfd_section->size != 0
|| (r->last_os == NULL
@@ -5219,6 +5222,9 @@ lang_size_sections_1
&& !bfd_link_relocatable (&link_info))
r->last_os = s;
if (bfd_is_abs_section (os->bfd_section) || os->ignored)
break;
/* .tbss sections effectively have zero size. */
if (!IS_TBSS (os->bfd_section)
|| bfd_link_relocatable (&link_info))