Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

gdbsupport: make gdb_open_cloexec return scoped_fd

Browse Source 
Make gdb_open_cloexec return a scoped_fd, to encourage using automatic
management of the file descriptor closing.  Except in the most trivial
cases, I changed the callers to just release the fd, which retains their
existing behavior.  That will allow the transition to using scoped_fd
more to go gradually, one caller at a time.

Change-Id: Ife022b403f96e71d5ebb4f1056ef6251b30fe554
This commit is contained in:
Simon Marchi
2021-07-22 11:56:33 -04:00
parent e6e51c9c4b
commit 13084383e8
16 changed files with 41 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gdb/gdb_bfd.c
View File

@@ -541,7 +541,7 @@ gdb_bfd_open (const char *name, const char *target, int fd,
if (fd == -1)
{
fd = gdb_open_cloexec (name, O_RDONLY | O_BINARY, 0);
fd = gdb_open_cloexec (name, O_RDONLY | O_BINARY, 0).release ();
if (fd == -1)
{
bfd_set_error (bfd_error_system_call);