Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Comment and whitespace changes

Browse Source 
Comments on the various implementations of target fileio functions
duplicate information documented in target.h.  This commit replaces
the duplicated documentation with breadcrumbs, and inserts blank
lines to separate comments from the functions they describe where
necessary.

gdb/ChangeLog:

	* inf-child.c (inf_child_fileio_open): Replace comment.
	(inf_child_fileio_pwrite): Likewise.
	(inf_child_fileio_pread): Likewise.
	(inf_child_fileio_fstat): Insert blank line before comment.
	(inf_child_fileio_close): Replace comment.
	(inf_child_fileio_unlink): Likewise.
	(inf_child_fileio_readlink): Likewise.
	* remote.c (remote_hostio_open): Likewise.
	(remote_hostio_pread): Likewise.
	(remote_hostio_pwrite): Likewise.
	(remote_hostio_close): Likewise.
	(remote_hostio_unlink): Likewise.
	(remote_hostio_readlink): Likewise.
	(remote_hostio_fstat): Likewise.
	(remote_filesystem_is_local): Likewise.
	* target.c (target_fileio_open): Likewise.
	(target_fileio_pwrite): Likewise.
	(target_fileio_pread): Likewise.
	(target_fileio_fstat): Insert blank line before comment.
	(target_fileio_close): Replace comment.
	(target_fileio_unlink): Likewise.
	(target_fileio_readlink): Likewise.
	(target_fileio_read_alloc): Likewise.
	(target_fileio_read_stralloc): Likewise.
This commit is contained in:
Gary Benson
2015-06-10 14:28:43 +01:00
parent 9bc3a9760b
commit 12e2a5fdcc
4 changed files with 63 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
gdb/remote.c
View File

@@ -10213,9 +10213,7 @@ remote_hostio_send_command (int command_bytes, int which_packet,
return ret;
}
/* Open FILENAME on the remote target, using FLAGS and MODE. Return a
remote file descriptor, or -1 if an error occurs (and set
*REMOTE_ERRNO). */
/* Implementation of to_fileio_open. */
static int
remote_hostio_open (struct target_ops *self,
@@ -10241,9 +10239,7 @@ remote_hostio_open (struct target_ops *self,
remote_errno, NULL, NULL);
}
/* Write up to LEN bytes from WRITE_BUF to FD on the remote target.
Return the number of bytes written, or -1 if an error occurs (and
set *REMOTE_ERRNO). */
/* Implementation of to_fileio_pwrite. */
static int
remote_hostio_pwrite (struct target_ops *self,
@@ -10270,9 +10266,7 @@ remote_hostio_pwrite (struct target_ops *self,
remote_errno, NULL, NULL);
}
/* Read up to LEN bytes FD on the remote target into READ_BUF
Return the number of bytes read, or -1 if an error occurs (and
set *REMOTE_ERRNO). */
/* Implementation of to_fileio_pread. */
static int
remote_hostio_pread (struct target_ops *self,
@@ -10311,8 +10305,7 @@ remote_hostio_pread (struct target_ops *self,
return ret;
}
/* Close FD on the remote target. Return 0, or -1 if an error occurs
(and set *REMOTE_ERRNO). */
/* Implementation of to_fileio_close. */
static int
remote_hostio_close (struct target_ops *self, int fd, int *remote_errno)
@@ -10329,8 +10322,7 @@ remote_hostio_close (struct target_ops *self, int fd, int *remote_errno)
remote_errno, NULL, NULL);
}
/* Unlink FILENAME on the remote target. Return 0, or -1 if an error
occurs (and set *REMOTE_ERRNO). */
/* Implementation of to_fileio_unlink. */
static int
remote_hostio_unlink (struct target_ops *self,
@@ -10349,9 +10341,7 @@ remote_hostio_unlink (struct target_ops *self,
remote_errno, NULL, NULL);
}
/* Read value of symbolic link FILENAME on the remote target. Return
a null-terminated string allocated via xmalloc, or NULL if an error
occurs (and set *REMOTE_ERRNO). */
/* Implementation of to_fileio_readlink. */
static char *
remote_hostio_readlink (struct target_ops *self,
@@ -10388,9 +10378,7 @@ remote_hostio_readlink (struct target_ops *self,
return ret;
}
/* Read information about the open file FD on the remote target
into ST. Return 0 on success, or -1 if an error occurs (and
set *REMOTE_ERRNO). */
/* Implementation of to_fileio_fstat. */
static int
remote_hostio_fstat (struct target_ops *self,
@@ -10450,8 +10438,7 @@ remote_hostio_fstat (struct target_ops *self,
return 0;
}
/* Return nonzero if the filesystem accessed by the target_fileio_*
methods is the local filesystem, zero otherwise. */
/* Implementation of to_filesystem_is_local. */
static int
remote_filesystem_is_local (struct target_ops *self)