Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

[gdb/testsuite] Simplify gdb.server/server-kill-python.exp

Browse Source 
In test-case gdb.server/server-kill-python.exp we have:
...
if {[gdb_spawn_with_cmdline_opts \
         "-quiet -iex \"set height 0\" -iex \"set width 0\" -ex \"source $host_file1\""] != 0} {
    fail "spawn"
    return
}
...

I reproduced the problem by reverting the fix at the commit adding both the
fix and the test-case, and the reproduced the same problem using:
...
(gdb) source $host_file1
...
so there doesn't seem to be a specific need to source the python file using
"-ex".

Simplify the test-case by sourcing the python file using send_gdb.

This also allow us to simplify the python script.

Tested on x86_64-linux.
This commit is contained in:
Tom de Vries
2024-04-17 11:45:02 +02:00
parent e59144c6ed
commit 0f077fcae0
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/testsuite/gdb.server/server-kill-python.exp
View File

@@ -48,8 +48,6 @@ puts $fd \
"import gdb
def do_gdb_stuff ():
gdb.execute ('file $host_binfile')
gdb.execute ('target $gdbserver_protocol $gdbserver_gdbport')
gdb.execute ('break $srcfile:$break_linenr')
gdb.execute ('continue')
gdb.execute ('p server_pid')
@@ -63,11 +61,15 @@ set host_file1 [gdb_remote_download host $file1]
# Now start GDB, sourcing the python command file we generated above.
# Set the height and width so we don't end up at a paging prompt.
if {[gdb_spawn_with_cmdline_opts \
"-quiet -iex \"set height 0\" -iex \"set width 0\" -ex \"source $host_file1\""] != 0} {
"-quiet -iex \"set height 0\" -iex \"set width 0\""] != 0} {
fail "spawn"
return
}
gdb_load $binfile
gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport
send_gdb "source $host_file1\n"
# Get the gdbserver PID.
set gdbserver_pid 0