Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

[gdb/testsuite] Fix quoting issue in gdb.base/index-cache.exp

Browse Source 
For test-case gdb.base/index-cache.exp and remote host, this:
...
lassign [remote_exec host sh "-c \"rm $cache_dir/*.gdb-index\""] ret
...
gives us:
...
Executing on host: sh -c rm /tmp/tmp.m3L7m2AVkL/*.gdb-index    (timeout = 300)
builtin_spawn -ignore SIGHUP sh -c rm /tmp/tmp.m3L7m2AVkL/*.gdb-index^M
rm: missing operand^M
Try 'rm --help' for more information.^M
FAIL: gdb.dwarf2/per-bfd-sharing.exp: couldn't remove files in temporary cache dir
...

Fix this using quote_for_host.  Likewise in gdb.dwarf2/per-bfd-sharing.exp.

Tested on x86_64-linux.
This commit is contained in:
Tom de Vries
2023-03-27 13:58:09 +02:00
parent d0498b325e
commit 0ecbda2f31
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gdb/testsuite/gdb.base/index-cache.exp
View File

@@ -245,7 +245,7 @@ test_cache_enabled_hit $cache_dir
# Test again with the cache disabled, now that it is populated. # Test again with the cache disabled, now that it is populated.
test_cache_disabled $cache_dir "after populate" test_cache_disabled $cache_dir "after populate"
lassign [remote_exec host sh "-c \"rm $cache_dir/*.gdb-index\""] ret lassign [remote_exec host "sh -c" [quote_for_host rm $cache_dir/*.gdb-index]] ret
if { $ret != 0 && $expecting_index_cache_use } { if { $ret != 0 && $expecting_index_cache_use } {
fail "couldn't remove files in temporary cache dir" fail "couldn't remove files in temporary cache dir"
return return

2
gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp
View File

@@ -96,7 +96,7 @@ foreach_with_prefix first $methods {
} }
} }
lassign [remote_exec host sh "-c \"rm $cache_dir/*.gdb-index\""] ret lassign [remote_exec host "sh -c" [quote_for_host rm $cache_dir/*.gdb-index]] ret
if { $ret != 0 && $expecting_index_cache_use } { if { $ret != 0 && $expecting_index_cache_use } {
fail "couldn't remove files in temporary cache dir" fail "couldn't remove files in temporary cache dir"
return return