Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Emit a note warning the user that creating an executable stack because of a missing .note.GNU-stack section is deprecated.

Browse Source 
PR 29072
bfd	* elflink.c (bfd_elf_size_dynamic_sections): Display a note to the
	user that the current ehaviour of creating an executable stack
	because of a missing .note.GNU-stack section is deprecated and
	will be changed in a future release.

binutils* testsuite/lib/binutils-common.exp (prune_warnings_extra): Filter
	out notes about the executable stacjk behaviour beign deprecated.

ld	* testsuite/ld-elf/pr29072.b.warn: Update to include the note
	about the linker's behaviour being depreccated.
This commit is contained in:
Nick Clifton
2022-04-25 12:51:31 +01:00
parent 5f59e7e0c7
commit 0d38576a34
6 changed files with 28 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
bfd/ChangeLog
View File

@@ -1,3 +1,11 @@
2022-04-25 Nick Clifton <nickc@redhat.com>
PR 29072
* elflink.c (bfd_elf_size_dynamic_sections): Display a note to the
user that the current ehaviour of creating an executable stack
because of a missing .note.GNU-stack section is deprecated and
will be changed in a future release.
2022-04-20 Clément Chigot <clement.chigot@atos.net> 2022-04-20 Clément Chigot <clement.chigot@atos.net>
* coff-rs6000.c (xcoff_reloc_type_noop): Add info argument. * coff-rs6000.c (xcoff_reloc_type_noop): Add info argument.

4
bfd/elflink.c
View File

@@ -7190,9 +7190,13 @@ warning: enabling an executable stack because of -z execstack command line optio
warning: %s: requires executable stack (because the .note.GNU-stack section is executable)"), warning: %s: requires executable stack (because the .note.GNU-stack section is executable)"),
bfd_get_filename (noteobj)); bfd_get_filename (noteobj));
else if (emptyobj) else if (emptyobj)
{
_bfd_error_handler (_("\ _bfd_error_handler (_("\
warning: %s: missing .note.GNU-stack section implies executable stack"), warning: %s: missing .note.GNU-stack section implies executable stack"),
bfd_get_filename (emptyobj)); bfd_get_filename (emptyobj));
_bfd_error_handler (_("\
NOTE: This behaviour is deprecated and will be removed in a future version of the linker"));
}
} }
} }
elf_stack_flags (output_bfd) = PF_R | PF_W | exec; elf_stack_flags (output_bfd) = PF_R | PF_W | exec;

6
binutils/ChangeLog
View File

@@ -1,3 +1,9 @@
2022-04-25 Nick Clifton <nickc@redhat.com>
PR 29072
* testsuite/lib/binutils-common.exp (prune_warnings_extra): Filter
out notes about the executable stacjk behaviour beign deprecated.
2022-04-12 Nick Clifton <nickc@redhat.com> 2022-04-12 Nick Clifton <nickc@redhat.com>
PR 28992 PR 28992

1
binutils/testsuite/lib/binutils-common.exp
View File

@@ -638,6 +638,7 @@ proc prune_warnings_extra { text } {
# PR binutils/23898: It is OK to have gaps in build notes. # PR binutils/23898: It is OK to have gaps in build notes.
regsub -all "(^|\n)(\[^\n\]*: Warning: Gap in build notes detected from\[^\n\]*\n?)+" $text "\\1" text regsub -all "(^|\n)(\[^\n\]*: Warning: Gap in build notes detected from\[^\n\]*\n?)+" $text "\\1" text
regsub -all "(^|\n)(\[^\n\]*: warning:\[^\n\]*missing \\.note\\.GNU-stack section\[^\n\]*\n?)+" $text "\\1" text regsub -all "(^|\n)(\[^\n\]*: warning:\[^\n\]*missing \\.note\\.GNU-stack section\[^\n\]*\n?)+" $text "\\1" text
regsub -all "(^|\n)(\[^\n\]*: NOTE: This behaviour is deprecated\[^\n\]*\n?)+" $text "\\1" text
return $text return $text
} }

6
ld/ChangeLog
View File

@@ -1,3 +1,9 @@
2022-04-25 Nick Clifton <nickc@redhat.com>
PR 29072
* testsuite/ld-elf/pr29072.b.warn: Update to include the note
about the linker's behaviour being depreccated.
2022-04-20 Clément Chigot <clement.chigot@atos.net> 2022-04-20 Clément Chigot <clement.chigot@atos.net>
* emultempl/aix.em (params): New variable. * emultempl/aix.em (params): New variable.

1
ld/testsuite/ld-elf/pr29072.b.warn
View File

@@ -1 +1,2 @@
.*: warning: .*\.o: missing \.note\.GNU-stack section implies executable stack .*: warning: .*\.o: missing \.note\.GNU-stack section implies executable stack
.*: NOTE: This behaviour is deprecated and will be removed in a future version of the linker