Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

[AArch64,arm] Fix some formatting issues in the aarch64/arm codebase

Browse Source 
As noted by Tom Tromey, there are some formatting issues with the ternary
operator in the aarch64/arm codebase.  This patch fixes those.

Reviewed-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Luis Machado
2023-06-09 15:36:34 +01:00
parent a3859ffba3
commit 05d63bafad
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gdb/aarch64-tdep.c
View File

@@ -946,7 +946,7 @@ aarch64_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc)
limit_pc = pc + 128; /* Magic. */ limit_pc = pc + 128; /* Magic. */
limit_pc limit_pc
= func_end_addr == 0? limit_pc : std::min (limit_pc, func_end_addr - 4); = func_end_addr == 0 ? limit_pc : std::min (limit_pc, func_end_addr - 4);
/* Try disassembling prologue. */ /* Try disassembling prologue. */
return aarch64_analyze_prologue (gdbarch, pc, limit_pc, NULL); return aarch64_analyze_prologue (gdbarch, pc, limit_pc, NULL);

20
gdb/arm-tdep.c
View File

@@ -1504,7 +1504,7 @@ thumb_analyze_prologue (struct gdbarch *gdbarch,
arm_debug_printf ("Found pacbti instruction at %s", arm_debug_printf ("Found pacbti instruction at %s",
paddress (gdbarch, start)); paddress (gdbarch, start));
arm_debug_printf ("RA is %s", arm_debug_printf ("RA is %s",
*ra_signed_state? "signed" : "not signed"); *ra_signed_state ? "signed" : "not signed");
cache->ra_signed_state = ra_signed_state; cache->ra_signed_state = ra_signed_state;
} }
@@ -1847,10 +1847,10 @@ arm_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc)
/* Set the correct adjustment based on whether the function is thumb mode or /* Set the correct adjustment based on whether the function is thumb mode or
not. We use it to get the address of the last instruction in the not. We use it to get the address of the last instruction in the
function (as opposed to the first address of the next function). */ function (as opposed to the first address of the next function). */
CORE_ADDR adjustment = func_is_thumb? 2 : 4; CORE_ADDR adjustment = func_is_thumb ? 2 : 4;
limit_pc limit_pc
= func_end_addr == 0? limit_pc : std::min (limit_pc, = func_end_addr == 0 ? limit_pc : std::min (limit_pc,
func_end_addr - adjustment); func_end_addr - adjustment);
/* Check if this is Thumb code. */ /* Check if this is Thumb code. */
@@ -8625,7 +8625,7 @@ arm_displaced_init_closure (struct gdbarch *gdbarch, CORE_ADDR from,
arm_gdbarch_tdep *tdep = gdbarch_tdep<arm_gdbarch_tdep> (gdbarch); arm_gdbarch_tdep *tdep = gdbarch_tdep<arm_gdbarch_tdep> (gdbarch);
unsigned int i, len, offset; unsigned int i, len, offset;
enum bfd_endian byte_order_for_code = gdbarch_byte_order_for_code (gdbarch); enum bfd_endian byte_order_for_code = gdbarch_byte_order_for_code (gdbarch);
int size = dsc->is_thumb? 2 : 4; int size = dsc->is_thumb ? 2 : 4;
const gdb_byte *bkp_insn; const gdb_byte *bkp_insn;
offset = 0; offset = 0;
@@ -10935,13 +10935,13 @@ arm_dump_tdep (struct gdbarch *gdbarch, struct ui_file *file)
gdb_printf (file, _("arm_dump_tdep: vfp_register_count = %i\n"), gdb_printf (file, _("arm_dump_tdep: vfp_register_count = %i\n"),
(int) tdep->vfp_register_count); (int) tdep->vfp_register_count);
gdb_printf (file, _("arm_dump_tdep: have_s_pseudos = %s\n"), gdb_printf (file, _("arm_dump_tdep: have_s_pseudos = %s\n"),
tdep->have_s_pseudos? "true" : "false"); tdep->have_s_pseudos ? "true" : "false");
gdb_printf (file, _("arm_dump_tdep: s_pseudo_base = %i\n"), gdb_printf (file, _("arm_dump_tdep: s_pseudo_base = %i\n"),
(int) tdep->s_pseudo_base); (int) tdep->s_pseudo_base);
gdb_printf (file, _("arm_dump_tdep: s_pseudo_count = %i\n"), gdb_printf (file, _("arm_dump_tdep: s_pseudo_count = %i\n"),
(int) tdep->s_pseudo_count); (int) tdep->s_pseudo_count);
gdb_printf (file, _("arm_dump_tdep: have_q_pseudos = %s\n"), gdb_printf (file, _("arm_dump_tdep: have_q_pseudos = %s\n"),
tdep->have_q_pseudos? "true" : "false"); tdep->have_q_pseudos ? "true" : "false");
gdb_printf (file, _("arm_dump_tdep: q_pseudo_base = %i\n"), gdb_printf (file, _("arm_dump_tdep: q_pseudo_base = %i\n"),
(int) tdep->q_pseudo_base); (int) tdep->q_pseudo_base);
gdb_printf (file, _("arm_dump_tdep: q_pseudo_count = %i\n"), gdb_printf (file, _("arm_dump_tdep: q_pseudo_count = %i\n"),
@@ -10949,7 +10949,7 @@ arm_dump_tdep (struct gdbarch *gdbarch, struct ui_file *file)
gdb_printf (file, _("arm_dump_tdep: have_neon = %i\n"), gdb_printf (file, _("arm_dump_tdep: have_neon = %i\n"),
(int) tdep->have_neon); (int) tdep->have_neon);
gdb_printf (file, _("arm_dump_tdep: have_mve = %s\n"), gdb_printf (file, _("arm_dump_tdep: have_mve = %s\n"),
tdep->have_mve? "yes" : "no"); tdep->have_mve ? "yes" : "no");
gdb_printf (file, _("arm_dump_tdep: mve_vpr_regnum = %i\n"), gdb_printf (file, _("arm_dump_tdep: mve_vpr_regnum = %i\n"),
tdep->mve_vpr_regnum); tdep->mve_vpr_regnum);
gdb_printf (file, _("arm_dump_tdep: mve_pseudo_base = %i\n"), gdb_printf (file, _("arm_dump_tdep: mve_pseudo_base = %i\n"),
@@ -10971,13 +10971,13 @@ arm_dump_tdep (struct gdbarch *gdbarch, struct ui_file *file)
gdb_printf (file, _("arm_dump_tdep: Lowest pc = 0x%lx\n"), gdb_printf (file, _("arm_dump_tdep: Lowest pc = 0x%lx\n"),
(unsigned long) tdep->lowest_pc); (unsigned long) tdep->lowest_pc);
gdb_printf (file, _("arm_dump_tdep: have_pacbti = %s\n"), gdb_printf (file, _("arm_dump_tdep: have_pacbti = %s\n"),
tdep->have_pacbti? "yes" : "no"); tdep->have_pacbti ? "yes" : "no");
gdb_printf (file, _("arm_dump_tdep: pacbti_pseudo_base = %i\n"), gdb_printf (file, _("arm_dump_tdep: pacbti_pseudo_base = %i\n"),
tdep->pacbti_pseudo_base); tdep->pacbti_pseudo_base);
gdb_printf (file, _("arm_dump_tdep: pacbti_pseudo_count = %i\n"), gdb_printf (file, _("arm_dump_tdep: pacbti_pseudo_count = %i\n"),
tdep->pacbti_pseudo_count); tdep->pacbti_pseudo_count);
gdb_printf (file, _("arm_dump_tdep: is_m = %s\n"), gdb_printf (file, _("arm_dump_tdep: is_m = %s\n"),
tdep->is_m? "yes" : "no"); tdep->is_m ? "yes" : "no");
} }
#if GDB_SELF_TEST #if GDB_SELF_TEST
@@ -12328,7 +12328,7 @@ arm_record_ld_st_reg_offset (arm_insn_decode_record *arm_insn_r)
break; break;
case 1: case 1:
offset_12 = (!shift_imm)?0:u_regval[0] >> shift_imm; offset_12 = (!shift_imm) ? 0 : u_regval[0] >> shift_imm;
break; break;
case 2: case 2: