Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Fix bug in Ada number lexing

Browse Source 
On irc, Pedro pointed out that Ada couldn't properly handle
0xffffffffffffffff.  This used to work, but is a regression due to
some patches I wrote in the Ada lexer.  This patch fixes the bug.
This commit is contained in:
Tom Tromey
2022-04-08 10:11:58 -06:00
parent 81f81faa8f
commit 0349d33f1d
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ada-lex.l
View File

@@ -434,11 +434,11 @@ processInt (struct parser_state *par_state, const char *base0,
return FLOAT; return FLOAT;
} }
gdb_mpz maxval (ULONGEST_MAX / base); gdb_mpz maxval (ULONGEST_MAX);
if (mpz_cmp (result.val, maxval.val) > 0) if (mpz_cmp (result.val, maxval.val) > 0)
error (_("Integer literal out of range")); error (_("Integer literal out of range"));
LONGEST value = result.as_integer<LONGEST> (); ULONGEST value = result.as_integer<ULONGEST> ();
if ((value >> (gdbarch_int_bit (par_state->gdbarch ())-1)) == 0) if ((value >> (gdbarch_int_bit (par_state->gdbarch ())-1)) == 0)
yylval.typed_val.type = type_int (par_state); yylval.typed_val.type = type_int (par_state);
else if ((value >> (gdbarch_long_bit (par_state->gdbarch ())-1)) == 0) else if ((value >> (gdbarch_long_bit (par_state->gdbarch ())-1)) == 0)

3
gdb/testsuite/gdb.ada/literals.exp
View File

@@ -34,3 +34,6 @@ gdb_test "print 2e1000" "Integer literal out of range"
gdb_test "print 16#ffff#" " = 65535" gdb_test "print 16#ffff#" " = 65535"
gdb_test "print 16#f#e1" " = 240" gdb_test "print 16#f#e1" " = 240"
gdb_test "print 16#1#e10" " = 1099511627776" gdb_test "print 16#1#e10" " = 1099511627776"
gdb_test "print/x 16#7fffffffffffffff#" " = 0x7fffffffffffffff"
gdb_test "print 16#ffffffffffffffff#" " = -1"