From a9fe71ea8df2db8f025dcc51a75b24d484e2fefd Mon Sep 17 00:00:00 2001 From: Adam Felizzi Date: Thu, 9 Aug 2018 14:24:17 +1000 Subject: [PATCH] tools: Added astyle,pylint and xmllint checks Added small bash scripts to run astyle, pylint and xmllint checks over the kernel source. These style checks were ported from the old Make build system. --- tools/kernel_astyle.sh | 21 +++++++++++++++++++++ tools/kernel_pylint.sh | 26 ++++++++++++++++++++++++++ tools/kernel_xmllint.sh | 27 +++++++++++++++++++++++++++ 3 files changed, 74 insertions(+) create mode 100755 tools/kernel_astyle.sh create mode 100755 tools/kernel_pylint.sh create mode 100755 tools/kernel_xmllint.sh diff --git a/tools/kernel_astyle.sh b/tools/kernel_astyle.sh new file mode 100755 index 000000000..c51da8b2d --- /dev/null +++ b/tools/kernel_astyle.sh @@ -0,0 +1,21 @@ +#!/bin/bash + +# +# Copyright 2018, Data61 +# Commonwealth Scientific and Industrial Research Organisation (CSIRO) +# ABN 41 687 119 230. +# +# This software may be distributed and modified according to the terms of +# the BSD 2-Clause license. Note that NO WARRANTY is provided. +# See "LICENSE_BSD2.txt" for details. +# +# @TAG(DATA61_BSD) +# + +kernel_sources=$(find ../src ../include ../libsel4 -name '*.[ch]') +if [[ -z $kernel_sources ]]; then + echo "Unable to find kernel source files" + exit 1 +fi + +astyle --max-instatement-indent=120 --style=otbs --pad-header --indent=spaces=4 --pad-oper ${kernel_sources} diff --git a/tools/kernel_pylint.sh b/tools/kernel_pylint.sh new file mode 100755 index 000000000..0f03067b7 --- /dev/null +++ b/tools/kernel_pylint.sh @@ -0,0 +1,26 @@ +#!/bin/bash + +# +# Copyright 2018, Data61 +# Commonwealth Scientific and Industrial Research Organisation (CSIRO) +# ABN 41 687 119 230. +# +# This software may be distributed and modified according to the terms of +# the BSD 2-Clause license. Note that NO WARRANTY is provided. +# See "LICENSE_BSD2.txt" for details. +# +# @TAG(DATA61_BSD) +# + +python_sources=$(find ../tools ../manual/tools ../libsel4/tools -name '*.py') +if [[ -z $python_sources ]]; then + echo "Unable to find python source files" + exit 1 +fi +pylintrc=$(find . -name 'pylintrc') +if [[ -z $pylintrc ]]; then + echo "Unable to find pylintrc" + exit 1 +fi + +pylint --errors-only --rcfile=${pylintrc} ${python_sources} diff --git a/tools/kernel_xmllint.sh b/tools/kernel_xmllint.sh new file mode 100755 index 000000000..c95ce85b8 --- /dev/null +++ b/tools/kernel_xmllint.sh @@ -0,0 +1,27 @@ +#!/bin/bash + +# +# Copyright 2018, Data61 +# Commonwealth Scientific and Industrial Research Organisation (CSIRO) +# ABN 41 687 119 230. +# +# This software may be distributed and modified according to the terms of +# the BSD 2-Clause license. Note that NO WARRANTY is provided. +# See "LICENSE_BSD2.txt" for details. +# +# @TAG(DATA61_BSD) +# + +xml_sources=$(find ../libsel4/arch_include/*/interfaces ../libsel4/sel4_arch_include/*/interfaces -name 'sel4arch.xml') +if [[ -z $xml_sources ]]; then + echo "Unable to find sel4arch.xml files" + exit 1 +fi + +idl_source=$(find ../libsel4/tools -name 'sel4_idl.dtd') +if [[ -z $idl_source ]]; then + echo "Unable to find sel4_idl.dtd" + exit 1 +fi + +xmllint --dtdvalid ${idl_source} --noout ${xml_sources}