* ftpd/ftpd.c, libcsupport/include/sys/ioccom.h,
libcsupport/src/ioctl.c, libnetworking/kern/uipc_mbuf.c,
libnetworking/libc/inet_addr.c, libnetworking/net/ethernet.h,
libnetworking/net/if.c, libnetworking/net/if_ethersubr.c,
libnetworking/net/if_ppp.c, libnetworking/net/if_pppvar.h,
libnetworking/net/if_var.h, libnetworking/net/ppp_tty.c,
libnetworking/netinet/in_cksum.c, libnetworking/nfs/bootp_subr.c,
libnetworking/rtems/rtems_bsdnet_internal.h,
libnetworking/sys/mbuf.h, pppd/md4.c, pppd/pppd.h: Remove warnings
due to improper use of int which shows up on 16 bit targets. Added
ioctl_command_t since IOCTL command argument does not reliably fit
into 16 bits.
* ftpd/Makefile.am: Split preinstallation rules in to separate
preinstall.am-files.
* ftpd/preinstall.am: New (Generated from corresponding Makefile.am).
* pppd/Makefile.am: Use mkdir_p. Remove dirs from PRE/TMPINSTALL_FILES.
* rtems_servers/Makefile.am: Use mkdir_p. Remove dirs from PRE/TMPINSTALL_FILES.
* rtems_telnetd/Makefile.am: Use mkdir_p. Remove dirs from PRE/TMPINSTALL_FILES.
* rtems_webserver/Makefile.am: Use mkdir_p. Remove dirs from PRE/TMPINSTALL_FILES.
Makefile.am: Reflect having moved automake.
pppd/Makefile.am: Reflect having moved automake.
rtems_servers/Makefile.am: Reflect having moved automake.
rtems_telnetd/Makefile.am: Reflect having moved automake.
rtems_webserver/Makefile.am: Reflect having moved automake.
wrapup/Makefile.am: Reflect having moved automake.
* pppd/Makefile.am: Use .$(OBJEXT) instead of .o.
* rtems_servers/Makefile.am: Use .$(OBJEXT) instead of .o.
* rtems_telnetd/Makefile.am: Use .$(OBJEXT) instead of .o.
* rtems_webserver/Makefile.am: Use .$(OBJEXT) instead of .o.
* wrapup/Makefile.am: Use .$(OBJEXT) instead of .o.
* machine/Makefile.am: Use 'PREINSTALL_FILES ='.
* net/Makefile.am: Use 'PREINSTALL_FILES ='.
* netinet/Makefile.am: Use 'PREINSTALL_FILES ='.
* vm/Makefile.am: Use 'PREINSTALL_FILES ='.
* pppd/Makefile.am: Use 'PREINSTALL_FILES ='.
* sys/Makefile.am: Use 'PREINSTALL_FILES ='.
* rtems_servers/Makefile.am: Use 'PREINSTALL_FILES ='.
* arpa/Makefile.am: Use 'PREINSTALL_FILES ='.
* nfs/Makefile.am: Use 'PREINSTALL_FILES ='.
* rtems_webserver/Makefile.am: Use 'PREINSTALL_FILES ='.
* rtems/Makefile.am: Use 'PREINSTALL_FILES ='.
* rtems_telnetd/Makefile.am: Use 'PREINSTALL_FILES ='.
* Makefile.am, configure.in, rtems_servers/Makefile.am,
rtems_servers/telnetd.c, rtems_servers/telnetd.h,
rtems_telnetd/Makefile.am, rtems_telnetd/README, rtems_telnetd/icmds.c,
rtems_telnetd/pty.c, rtems_telnetd/pty.h, rtems_telnetd/telnetd.c,
rtems_telnetd/telnetd.h, wrapup/Makefile.am:
- pty and telnetd have a new subdir rtems_telnetd to avoid
the side effect when ftpd change.
- the tcp/ip stats have been implemented into icmds.c and
started when telnetd daemon is started.
* rtems_servers/telnetd.c, rtems_servers/telnetd.h: Removed.
* rtems_telnetd: New directory.
* rtems_telnetd/Makefile.am, rtems_telnetd/README,
rtems_telnetd/icmds.c, rtems_telnetd/pty.c, rtems_telnetd/pty.h,
rtems_telnetd/telnetd.c, rtems_telnetd/telnetd.h: New files.
* rtems_servers/telnetd.c, shell/telnetd.h: Moved from libmisc/shell
so the network stack to address network depenendency.
* rtems_servers/Makefile.am: Modified to reflect above.
* rtems_servers/ftp.d: Following changes:
- Hacks with current dir and root dir removed in favor of new libio
support for task-local current and root directories.
- Bug in `close_data_socket()' introduced by previous change fixed.
- `command_pasv()' changed to set timeout on socket we are listening
on and code fixed to don't close socket twice on error.
- `serr()' changed to clear `errno'.
- `data_socket()' changed to clear `errno' before `bind()'.
- `session()' changed to clear `errno' before processing session.
- `close_data_socket()' fixed to close both active and passive sockets
- Initialize info->data_socket to -1 in `daemon()'
- Initialize `fname' to empty string in `exec_command()'
* rtems_servers/ftpd.c, rtems_servers/ftpd.h: Major enhancements
as listed below:
- Timeouts on sockets implemented. 'idle' field added to
configuration. No timeout by default to keep backward compatibility.
Note: SITE IDLE command not implemented yet.
- Basic global access control implemented. 'access' field added to
configuration. No access limitations by default to keep backward
compatibility.
- Anchor data socket for active mode (using self IP and port 20.)
- Fixed default data port support (still not tested).
- Don't allow IP address different from originating host in
PORT command to improve security.
- Fixed bug in MDTM command.
- Check for correctness of parsing of argument in command_port().
- Fixed squeeze_path() to don't allow names like 'NAME/smth' where
'NAME' is not a directory.
- Command parsing a little bit improved: command names are now
converted to upper-case to be more compatible with RFC (command
names are not case-sensitive.)
- Reformat comments so that they have RTEMS look-and-feel.
- Fixed DELE, SITE CHMOD, RMD, MKD broken by previous changes
- True ASCII mode implemented (doesn't work for hooks and /dev/null)
- Passive mode implemented, PASV command added.
- Default port for data connection could be used (untested, can't find
ftp client that doesn't send PORT command)
- SYST reply changed to UNIX, as former RTEMS isn't registered name.
- Reply codes reviewed and fixed.
* rtems_servers/ftpd.c, rtems_servers/ftpd.h: Major enhancements
as listed below:
- use pool of pre-created threads to handle sessions instead of
creating/deleting threads on the fly
- LIST output is now similar to what "/bin/ls -al" would output,
thus FTP clients such Netscape are happy with it.
- LIST NAME now works (both for files and directories)
- added support for NLST, CDUP, and MDTM FTP commands to make
more FTP clients happy
- keep track of CWD for every session separately
- ability to specify root directory name for FTPD in configuration
table. FTPD will then create illusion for FTP clients that this
is actually root directory.
- ignore options sent in commands, thus LIST -al FILE works and
doesn't try to list "-al" directory.
- buffers are allocated on stack instead of heap where possible to
eliminate malloc/free calls (avoid possible heap fragmentation
troubles).
- drop using of task notepad to pass parameters - use function
arguments instead
- use snprintf() instead of sprintf() as the latter is unsafe
- use of PF_INET in socket() instead of AF_INET
Here are ftp clients I've tried new FTPD with (all of them
running on Debian GNU/Linux 2.2):
Lftp 2.1.10
NcFTP 2.4.3
Netscape 4.75
ftp
mc 4.5.49
that contains the automake files for libnetworking plus a couple of
minor fixes. [Now only one unused/unsupported Makefile.in remains
(./c/src/lib/libbsp/hppa1.1/pxfl/Makefile.in).]
To apply:
patch -p1 < rtems-rc-20000118-7.diff
/bin/sh rtems-rc-20000118-7.rm
/bin/sh rtems-rc-20000118-7.add
./bootstrap
Notes:
* I have tested this one by building all BSPs for m68k, powerpc, sh and
unix with toolchains built since last weekend.
* I did not touch libnetworking's directory layout.
