RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

dosfs: Always release the buffers

Browse Source 
Release the buffers also if this is not the last reference to the file
object since otherwise we may hold modified data indefinitely.
This commit is contained in:
Sebastian Huber
2013-01-30 10:31:40 +01:00
parent 1b937c6994
commit eefeefdd0e
1 changed files with 24 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
cpukit/libfs/src/dosfs/fat_file.c
View File

@@ -191,45 +191,46 @@ fat_file_close(
)
{
int rc = RC_OK;
uint32_t key = 0;
/*
* if links_num field of fat-file descriptor is greater than 1
* decrement the count of links and return
* decrement only the count of links
*/
if (fat_fd->links_num > 1)
{
fat_fd->links_num--;
return rc;
}
key = fat_construct_key(fs_info, &fat_fd->dir_pos.sname);
if (fat_fd->flags & FAT_FILE_REMOVED)
{
rc = fat_file_truncate(fs_info, fat_fd, 0);
if ( rc != RC_OK )
return rc;
_hash_delete(fs_info->rhash, key, fat_fd->ino, fat_fd);
if ( fat_ino_is_unique(fs_info, fat_fd->ino) )
fat_free_unique_ino(fs_info, fat_fd->ino);
free(fat_fd);
}
else
{
if (fat_ino_is_unique(fs_info, fat_fd->ino))
uint32_t key = fat_construct_key(fs_info, &fat_fd->dir_pos.sname);
if (fat_fd->flags & FAT_FILE_REMOVED)
{
fat_fd->links_num = 0;
rc = fat_file_truncate(fs_info, fat_fd, 0);
if (rc == RC_OK)
{
_hash_delete(fs_info->rhash, key, fat_fd->ino, fat_fd);
if (fat_ino_is_unique(fs_info, fat_fd->ino))
fat_free_unique_ino(fs_info, fat_fd->ino);
free(fat_fd);
}
}
else
{
_hash_delete(fs_info->vhash, key, fat_fd->ino, fat_fd);
free(fat_fd);
if (fat_ino_is_unique(fs_info, fat_fd->ino))
{
fat_fd->links_num = 0;
}
else
{
_hash_delete(fs_info->vhash, key, fat_fd->ino, fat_fd);
free(fat_fd);
}
}
}
/*
* flush any modified "cached" buffer back to disk
*/