objectsetname.c: Fix always true condition (Coverity ID 1063874)

Coverity spotted the comparison (0 <= length) which is always true.
Changed logic to address this.
This commit is contained in:
Joel Sherrill
2014-11-20 17:25:15 -06:00
parent abf3892c1a
commit ed4c5568c7

View File

@@ -6,7 +6,7 @@
*/
/*
* COPYRIGHT (c) 1989-2009.
* COPYRIGHT (c) 1989-2014.
* On-Line Applications Research Corporation (OAR).
*
* The license and distribution terms for this file may be
@@ -53,10 +53,10 @@ bool _Objects_Set_name(
#endif
{
the_object->name.name_u32 = _Objects_Build_name(
((0 <= length) ? s[ 0 ] : ' '),
((1 < length) ? s[ 1 ] : ' '),
((2 < length) ? s[ 2 ] : ' '),
((3 < length) ? s[ 3 ] : ' ')
((length) ? s[ 0 ] : ' '),
((length > 1) ? s[ 1 ] : ' '),
((length > 2) ? s[ 2 ] : ' '),
((length > 3) ? s[ 3 ] : ' ')
);
}