RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

shell: Simplify rtems_shell_dup_current_env()

Browse Source 
Do not assign members already provided by the global environment.
This commit is contained in:
Sebastian Huber
2022-04-05 16:47:59 +02:00
parent 1a8ad7e68f
commit e765cfb450
1 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
cpukit/libmisc/shell/shell.c
View File

@@ -53,7 +53,7 @@ const rtems_shell_env_t rtems_global_shell_env = {
.magic = rtems_build_name('S', 'E', 'N', 'V'),
.managed = false,
.devname = CONSOLE_DEVICE_NAME,
.taskname = "SHGL",
.taskname = "RTSH",
.exit_shell = false,
.forever = true,
.echo = false,
@@ -267,12 +267,13 @@ void rtems_shell_dup_current_env(rtems_shell_env_t *copy)
if (env != NULL) {
shell_std_debug("dup: existing parent\n");
*copy = *env;
}
else {
/*
* Duplicated environments are not managed.
*/
copy->managed = false;
} else {
*copy = rtems_global_shell_env;
copy->magic = rtems_build_name('S', 'E', 'N', 'V');
copy->devname = CONSOLE_DEVICE_NAME;
copy->taskname = "RTSH";
copy->parent_stdout = stdout;
copy->parent_stdin = stdin;
copy->parent_stderr = stderr;
@@ -281,10 +282,6 @@ void rtems_shell_dup_current_env(rtems_shell_env_t *copy)
fileno(copy->parent_stdout), copy->parent_stdout,
fileno(copy->parent_stdin), copy->parent_stdin);
}
/*
* Duplicated environments are not managed.
*/
copy->managed = false;
}
/*