RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

Changed all EFAULTs to EINVALs

Browse Source
This commit is contained in:
Mark Johannes
1996-08-19 15:30:25 +00:00
parent 02f041e40b
commit c5c5f8cb3e
2 changed files with 28 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
c/src/exec/posix/src/psignal.c
View File

@@ -498,7 +498,7 @@ int sigemptyset(
) )
{ {
if ( !set ) if ( !set )
set_errno_and_return_minus_one( EFAULT ); set_errno_and_return_minus_one( EINVAL );
*set = 0; *set = 0;
return 0; return 0;
@@ -513,7 +513,7 @@ int sigfillset(
) )
{ {
if ( !set ) if ( !set )
set_errno_and_return_minus_one( EFAULT ); set_errno_and_return_minus_one( EINVAL );
*set = SIGNAL_ALL_MASK; *set = SIGNAL_ALL_MASK;
return 0; return 0;
@@ -529,7 +529,7 @@ int sigaddset(
) )
{ {
if ( !set ) if ( !set )
set_errno_and_return_minus_one( EFAULT ); set_errno_and_return_minus_one( EINVAL );
if ( !signo ) if ( !signo )
return 0; return 0;
@@ -551,7 +551,7 @@ int sigdelset(
) )
{ {
if ( !set ) if ( !set )
set_errno_and_return_minus_one( EFAULT ); set_errno_and_return_minus_one( EINVAL );
if ( !signo ) if ( !signo )
return 0; return 0;
@@ -573,7 +573,7 @@ int sigismember(
) )
{ {
if ( !set ) if ( !set )
set_errno_and_return_minus_one( EFAULT ); set_errno_and_return_minus_one( EINVAL );
if ( !signo ) if ( !signo )
return 0; return 0;
@@ -687,7 +687,7 @@ int pthread_sigmask(
POSIX_API_Control *api; POSIX_API_Control *api;
if ( !set && !oset ) if ( !set && !oset )
set_errno_and_return_minus_one( EFAULT ); set_errno_and_return_minus_one( EINVAL );
api = _Thread_Executing->API_Extensions[ THREAD_API_POSIX ]; api = _Thread_Executing->API_Extensions[ THREAD_API_POSIX ];
@@ -735,7 +735,7 @@ int sigpending(
POSIX_API_Control *api; POSIX_API_Control *api;
if ( !set ) if ( !set )
set_errno_and_return_minus_one( EFAULT ); set_errno_and_return_minus_one( EINVAL );
api = _Thread_Executing->API_Extensions[ THREAD_API_POSIX ]; api = _Thread_Executing->API_Extensions[ THREAD_API_POSIX ];
@@ -946,6 +946,13 @@ int killinfo(
if( pid != getpid() ) if( pid != getpid() )
set_errno_and_return_minus_one( ESRCH ); set_errno_and_return_minus_one( ESRCH );
/*
* Validate the signal passed if not 0.
*/
if ( sig && !is_valid_signo(sig) )
set_errno_and_return_minus_one( EINVAL );
/* /*
* If the signal is being ignored, then we are out of here. * If the signal is being ignored, then we are out of here.
*/ */

21
cpukit/posix/src/psignal.c
View File

@@ -498,7 +498,7 @@ int sigemptyset(
) )
{ {
if ( !set ) if ( !set )
set_errno_and_return_minus_one( EFAULT ); set_errno_and_return_minus_one( EINVAL );
*set = 0; *set = 0;
return 0; return 0;
@@ -513,7 +513,7 @@ int sigfillset(
) )
{ {
if ( !set ) if ( !set )
set_errno_and_return_minus_one( EFAULT ); set_errno_and_return_minus_one( EINVAL );
*set = SIGNAL_ALL_MASK; *set = SIGNAL_ALL_MASK;
return 0; return 0;
@@ -529,7 +529,7 @@ int sigaddset(
) )
{ {
if ( !set ) if ( !set )
set_errno_and_return_minus_one( EFAULT ); set_errno_and_return_minus_one( EINVAL );
if ( !signo ) if ( !signo )
return 0; return 0;
@@ -551,7 +551,7 @@ int sigdelset(
) )
{ {
if ( !set ) if ( !set )
set_errno_and_return_minus_one( EFAULT ); set_errno_and_return_minus_one( EINVAL );
if ( !signo ) if ( !signo )
return 0; return 0;
@@ -573,7 +573,7 @@ int sigismember(
) )
{ {
if ( !set ) if ( !set )
set_errno_and_return_minus_one( EFAULT ); set_errno_and_return_minus_one( EINVAL );
if ( !signo ) if ( !signo )
return 0; return 0;
@@ -687,7 +687,7 @@ int pthread_sigmask(
POSIX_API_Control *api; POSIX_API_Control *api;
if ( !set && !oset ) if ( !set && !oset )
set_errno_and_return_minus_one( EFAULT ); set_errno_and_return_minus_one( EINVAL );
api = _Thread_Executing->API_Extensions[ THREAD_API_POSIX ]; api = _Thread_Executing->API_Extensions[ THREAD_API_POSIX ];
@@ -735,7 +735,7 @@ int sigpending(
POSIX_API_Control *api; POSIX_API_Control *api;
if ( !set ) if ( !set )
set_errno_and_return_minus_one( EFAULT ); set_errno_and_return_minus_one( EINVAL );
api = _Thread_Executing->API_Extensions[ THREAD_API_POSIX ]; api = _Thread_Executing->API_Extensions[ THREAD_API_POSIX ];
@@ -946,6 +946,13 @@ int killinfo(
if( pid != getpid() ) if( pid != getpid() )
set_errno_and_return_minus_one( ESRCH ); set_errno_and_return_minus_one( ESRCH );
/*
* Validate the signal passed if not 0.
*/
if ( sig && !is_valid_signo(sig) )
set_errno_and_return_minus_one( EINVAL );
/* /*
* If the signal is being ignored, then we are out of here. * If the signal is being ignored, then we are out of here.
*/ */