From bec8f2b2efeb6efa0239d7193bcc2b2931d76908 Mon Sep 17 00:00:00 2001 From: Joel Sherrill Date: Mon, 21 Jun 2010 16:25:20 +0000 Subject: [PATCH] 2010-06-21 Joel Sherrill PR 1559/misc Coverity Id 16 * libmisc/monitor/mon-editor.c: Fix buffer overflow. --- cpukit/ChangeLog | 6 ++++++ cpukit/libmisc/monitor/mon-editor.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/cpukit/ChangeLog b/cpukit/ChangeLog index 1666873784..9d1324cd72 100644 --- a/cpukit/ChangeLog +++ b/cpukit/ChangeLog @@ -1,3 +1,9 @@ +2010-06-21 Joel Sherrill + + PR 1559/misc + Coverity Id 16 + * libmisc/monitor/mon-editor.c: Fix buffer overflow. + 2010-06-18 Ralf Corsépius * rtems/include/rtems/rtems/object.h, diff --git a/cpukit/libmisc/monitor/mon-editor.c b/cpukit/libmisc/monitor/mon-editor.c index 644560699b..1104b50185 100644 --- a/cpukit/libmisc/monitor/mon-editor.c +++ b/cpukit/libmisc/monitor/mon-editor.c @@ -428,7 +428,7 @@ rtems_monitor_line_editor ( if ((pos < end) && (end < RTEMS_COMMAND_BUFFER_SIZE)) { int ch, bs; - for (ch = end + 1; ch > pos; ch--) + for (ch = end; ch > pos; ch--) buffer[ch] = buffer[ch - 1]; fprintf(stdout,buffer + pos); for (bs = 0; bs < (end - pos + 1); bs++)