RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

cpukit/libmisc/monitor: Fix src/dest overlap of strcpy in mon-editor.c

Browse Source 
See also CID 1399727

Closes #4444
This commit is contained in:
Harrison Edward Gerber
2021-05-27 17:31:53 -07:00
committed by Vijay Kumar Banerjee
parent ea41722c92
commit 6a56fd9340
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
cpukit/libmisc/monitor/mon-editor.c
View File

@@ -360,7 +360,17 @@ rtems_monitor_line_editor (
{ {
int bs; int bs;
pos--; pos--;
strcpy (buffer + pos, buffer + pos + 1);
/*
* Memory operation used here instead of string
* method due the src and dest of buffer overlapping.
*/
memmove(
buffer + pos,
buffer + pos + 1,
RTEMS_COMMAND_BUFFER_SIZE - pos - 1
);
buffer[RTEMS_COMMAND_BUFFER_SIZE - 1] = '\0';
fprintf(stdout,"\b%s \b", buffer + pos); fprintf(stdout,"\b%s \b", buffer + pos);
for (bs = 0; bs < ((int) strlen (buffer) - pos); bs++) for (bs = 0; bs < ((int) strlen (buffer) - pos); bs++)
putchar ('\b'); putchar ('\b');