RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

Addressed this bug report:

Browse Source 
Date: Mon, 12 Apr 1999 00:38:04 +0000
From: Brendan Simon <brendan@dgs.monash.edu.au>
To: Jay Monkman <jmonkman@frasca.com>, "joel@OARcorp.com" <joel@oarcorp.com>
Subject: [Fwd: Goof in SMC initialize for mpc860]

Nick Simon reported this bug in the eth_comm BSP sources.  I see that it is
still there in the latest snapshot that Joel sent me (thanks).  I thought I
better forward this on to you guys.

Brendan.


Nick.SIMON@syntegra.bt.co.uk wrote:

> Sice I believe you're using the same base BSP as I am (you sent it to me) I
> thought I'd mention..
>
> In console-generic.c, in m860_smc_initialize, the receive buffer is malloced
> and assigned to RxBd[port+3]-> buffer - it should be [port-1].
>
> TTFN
B
This commit is contained in:
Joel Sherrill
1999-04-12 15:21:43 +00:00
parent 936ae5dd1f
commit 63b96b95ab
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
c/src/lib/libcpu/powerpc/mpc821/console-generic/console-generic.c
View File

@@ -417,7 +417,7 @@ m821_smc_initialize (int port) /* port is the SMC number (i.e. 1 or 2) */
RxBd[port-1]->status = M821_BD_EMPTY | M821_BD_WRAP |
M821_BD_INTERRUPT;
RxBd[port-1]->length = 0;
RxBd[port+3]->buffer = malloc(RXBUFSIZE);
RxBd[port-1]->buffer = malloc(RXBUFSIZE);
/*
* Setup the Transmit Buffer Descriptor

2
c/src/lib/libcpu/powerpc/mpc860/console-generic/console-generic.c
View File

@@ -431,7 +431,7 @@ m860_smc_initialize (int port) /* port is the SMC number (i.e. 1 or 2) */
RxBd[port-1]->status = M860_BD_EMPTY | M860_BD_WRAP |
M860_BD_INTERRUPT;
RxBd[port-1]->length = 0;
RxBd[port+3]->buffer = malloc(RXBUFSIZE);
RxBd[port-1]->buffer = malloc(RXBUFSIZE);
/*
* Setup the Transmit Buffer Descriptor