RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

dosfs: Unintentional integer overflow

Browse Source 
Explicitly promote 32-bit integer to 64-bits for multiplication.
This commit is contained in:
Gedare Bloom
2013-09-05 12:58:34 -04:00
parent 96654dcc1a
commit 551468c2db
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpukit/libfs/src/dosfs/msdos_format.c
View File

@@ -515,7 +515,7 @@ static int msdos_format_determine_fmt_params
ret_val = rtems_disk_fd_get_block_count(fd, &fmt_params->totl_sector_cnt); ret_val = rtems_disk_fd_get_block_count(fd, &fmt_params->totl_sector_cnt);
} }
if (ret_val == 0) { if (ret_val == 0) {
total_size = fmt_params->bytes_per_sector * fmt_params->totl_sector_cnt; total_size = (uint64_t)fmt_params->bytes_per_sector * fmt_params->totl_sector_cnt;
msdos_format_printf (rqdata, MSDOS_FMT_INFO_LEVEL_DETAIL, msdos_format_printf (rqdata, MSDOS_FMT_INFO_LEVEL_DETAIL,
"bytes per sector: %" PRIu32 "\ntotal sectors: %" PRIu32 "\ntotal size: %" PRIu64 "\n", "bytes per sector: %" PRIu32 "\ntotal sectors: %" PRIu32 "\ntotal size: %" PRIu64 "\n",
fmt_params->bytes_per_sector, fmt_params->totl_sector_cnt, total_size); fmt_params->bytes_per_sector, fmt_params->totl_sector_cnt, total_size);