forked from Imagelibrary/rtems
Changes that improve DTrace FBT reliability
on freebsd/arm64: - Implement a dtrace_getnanouptime(), matching the existing dtrace_getnanotime(), to avoid DTrace calling out to a potentially instrumentable function. (These should probably both be under KDTRACE_HOOKS. Also, it's not clear to me that they are correct implementations for the DTrace thread time functions they are used in .. fixes for another commit.) - Don't allow FBT to instrument functions involved in EL1 exception handling that are involved in FBT trap processing: handle_el1h_sync() and do_el1h_sync(). - Don't allow FBT to instrument DDB and KDB functions, as that makes it rather harder to debug FBT problems. Prior to these changes, use of FBT on FreeBSD/arm64 rapidly led to kernel panics due to recursion in DTrace. Reliable FBT on FreeBSD/arm64 is reliant on another change from @andrew to have the aarch64 instrumentor more carefully check that instructions it replaces are against the stack pointer, which can otherwise lead to memory corruption. That change remains under review. MFC after: 2 weeks Reviewed by: andrew, kp, markj (earlier version), jrtc27 (earlier version) Differential revision: https://reviews.freebsd.org/D27766
This commit is contained in:
committed by
Moyano, Gabriel
parent
62c428f241
commit
512e0b59af
@@ -284,6 +284,7 @@ static void _Timecounter_Windup(struct bintime *new_boottimebin,
|
|||||||
#endif /* __rtems__ */
|
#endif /* __rtems__ */
|
||||||
|
|
||||||
void dtrace_getnanotime(struct timespec *tsp);
|
void dtrace_getnanotime(struct timespec *tsp);
|
||||||
|
void dtrace_getnanouptime(struct timespec *tsp);
|
||||||
|
|
||||||
#ifndef __rtems__
|
#ifndef __rtems__
|
||||||
static int
|
static int
|
||||||
@@ -1156,6 +1157,20 @@ dtrace_getnanotime(struct timespec *tsp)
|
|||||||
|
|
||||||
GETTHMEMBER(tsp, th_nanotime);
|
GETTHMEMBER(tsp, th_nanotime);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/*
|
||||||
|
* This is a clone of getnanouptime used for time since boot.
|
||||||
|
* The dtrace_ prefix prevents fbt from creating probes for
|
||||||
|
* it so an uptime that can be safely used in all fbt probes.
|
||||||
|
*/
|
||||||
|
void
|
||||||
|
dtrace_getnanouptime(struct timespec *tsp)
|
||||||
|
{
|
||||||
|
struct bintime bt;
|
||||||
|
|
||||||
|
GETTHMEMBER(&bt, th_offset);
|
||||||
|
bintime2timespec(&bt, tsp);
|
||||||
|
}
|
||||||
#endif /* __rtems__ */
|
#endif /* __rtems__ */
|
||||||
|
|
||||||
#ifdef FFCLOCK
|
#ifdef FFCLOCK
|
||||||
|
|||||||
Reference in New Issue
Block a user