Synchronize all file descriptors in sync()

Synchronize all file descriptors and not just the ones associated with a FILE
object.

Close #4656.
This commit is contained in:
Sebastian Huber
2022-05-13 13:10:00 +02:00
parent 135d5274bd
commit 3ccfb58311

View File

@@ -1,15 +1,15 @@
/* SPDX-License-Identifier: BSD-2-Clause */ /* SPDX-License-Identifier: BSD-2-Clause */
/** /**
* @file * @file
* *
* @brief Synchronize Data on Disk with Memory * @ingroup libcsupport
* @ingroup libcsupport *
* @brief This source file contains the implementation of sync().
*/ */
/* /*
* COPYRIGHT (c) 1989-2008. * Copyright (C) 2022 embedded brains GmbH
* On-Line Applications Research Corporation (OAR).
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions * modification, are permitted provided that the following conditions
@@ -37,76 +37,16 @@
#include "config.h" #include "config.h"
#endif #endif
#include <sys/reent.h>
#include <unistd.h> #include <unistd.h>
#include <stdio.h>
#include <rtems.h> #include <rtems/libio_.h>
#include <rtems/score/thread.h>
#include <rtems/score/percpu.h>
/* In Newlib this function is declared in a private header file */ void sync( void )
int _fwalk_reent (struct _reent *, int (*)(struct _reent *, FILE *));
static int sync_wrapper(struct _reent *reent, FILE *f)
{ {
int fn = fileno(f); int fd;
(void) reent; for ( fd = 0; fd < (int) rtems_libio_number_iops; ++fd ) {
(void) fsync( fd );
/* (void) fdatasync( fd );
* There is no way to report errors here. So this is a best-effort approach. }
*/
(void) fsync(fn);
(void) fdatasync(fn);
return 0;
}
/* iterate over all FILE *'s for this thread */
static bool sync_per_thread(Thread_Control *t, void *arg)
{
struct _reent *current_reent;
struct _reent *this_reent;
/*
* The sync_wrapper() function will operate on the current thread's
* reent structure so we will temporarily use that.
*/
this_reent = t->libc_reent;
if ( this_reent ) {
Thread_Control *executing = _Thread_Get_executing();
current_reent = executing->libc_reent;
executing->libc_reent = this_reent;
_fwalk_reent (this_reent, sync_wrapper);
executing->libc_reent = current_reent;
}
return false;
}
/**
* This function operates by as follows:
* for all threads
* for all FILE *
* fsync()
* fdatasync()
*/
void sync(void)
{
/*
* Walk the one used initially by RTEMS.
*/
_fwalk_reent(_GLOBAL_REENT, sync_wrapper);
/*
* XXX Do we walk the one used globally by newlib?
* XXX Do we need the RTEMS global one?
*/
/*
* Now walk all the per-thread reentrancy structures.
*/
rtems_task_iterate(sync_per_thread, NULL);
} }