RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

Jennifer found some uninitialized variables:

Browse Source 
+ major and minor number elements in rtems_termios_open.

  + arg->ioctl_return in rtems_termios_ioctl routine.
This commit is contained in:
Joel Sherrill
1998-01-16 15:37:20 +00:00
parent ecacc1196c
commit 3a7782b09e
3 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
c/src/exec/libcsupport/src/termios.c
View File

@@ -207,6 +207,9 @@ rtems_termios_open (
if (ttyTail == NULL) if (ttyTail == NULL)
ttyTail = tty; ttyTail = tty;
tty->minor = minor;
tty->major = major;
/* /*
* Set up mutex semaphores * Set up mutex semaphores
*/ */
@@ -343,8 +346,10 @@ rtems_termios_ioctl (void *arg)
args->ioctl_return = 0; args->ioctl_return = 0;
sc = rtems_semaphore_obtain (tty->osem, RTEMS_WAIT, RTEMS_NO_TIMEOUT); sc = rtems_semaphore_obtain (tty->osem, RTEMS_WAIT, RTEMS_NO_TIMEOUT);
if (sc != RTEMS_SUCCESSFUL) if (sc != RTEMS_SUCCESSFUL) {
args->ioctl_return = sc;
return sc; return sc;
}
switch (args->command) { switch (args->command) {
default: default:
sc = RTEMS_INVALID_NUMBER; sc = RTEMS_INVALID_NUMBER;
@@ -387,6 +392,7 @@ rtems_termios_ioctl (void *arg)
break; break;
} }
rtems_semaphore_release (tty->osem); rtems_semaphore_release (tty->osem);
args->ioctl_return = sc;
return sc; return sc;
} }

8
c/src/lib/libc/termios.c
View File

@@ -207,6 +207,9 @@ rtems_termios_open (
if (ttyTail == NULL) if (ttyTail == NULL)
ttyTail = tty; ttyTail = tty;
tty->minor = minor;
tty->major = major;
/* /*
* Set up mutex semaphores * Set up mutex semaphores
*/ */
@@ -343,8 +346,10 @@ rtems_termios_ioctl (void *arg)
args->ioctl_return = 0; args->ioctl_return = 0;
sc = rtems_semaphore_obtain (tty->osem, RTEMS_WAIT, RTEMS_NO_TIMEOUT); sc = rtems_semaphore_obtain (tty->osem, RTEMS_WAIT, RTEMS_NO_TIMEOUT);
if (sc != RTEMS_SUCCESSFUL) if (sc != RTEMS_SUCCESSFUL) {
args->ioctl_return = sc;
return sc; return sc;
}
switch (args->command) { switch (args->command) {
default: default:
sc = RTEMS_INVALID_NUMBER; sc = RTEMS_INVALID_NUMBER;
@@ -387,6 +392,7 @@ rtems_termios_ioctl (void *arg)
break; break;
} }
rtems_semaphore_release (tty->osem); rtems_semaphore_release (tty->osem);
args->ioctl_return = sc;
return sc; return sc;
} }

8
cpukit/libcsupport/src/termios.c
View File

@@ -207,6 +207,9 @@ rtems_termios_open (
if (ttyTail == NULL) if (ttyTail == NULL)
ttyTail = tty; ttyTail = tty;
tty->minor = minor;
tty->major = major;
/* /*
* Set up mutex semaphores * Set up mutex semaphores
*/ */
@@ -343,8 +346,10 @@ rtems_termios_ioctl (void *arg)
args->ioctl_return = 0; args->ioctl_return = 0;
sc = rtems_semaphore_obtain (tty->osem, RTEMS_WAIT, RTEMS_NO_TIMEOUT); sc = rtems_semaphore_obtain (tty->osem, RTEMS_WAIT, RTEMS_NO_TIMEOUT);
if (sc != RTEMS_SUCCESSFUL) if (sc != RTEMS_SUCCESSFUL) {
args->ioctl_return = sc;
return sc; return sc;
}
switch (args->command) { switch (args->command) {
default: default:
sc = RTEMS_INVALID_NUMBER; sc = RTEMS_INVALID_NUMBER;
@@ -387,6 +392,7 @@ rtems_termios_ioctl (void *arg)
break; break;
} }
rtems_semaphore_release (tty->osem); rtems_semaphore_release (tty->osem);
args->ioctl_return = sc;
return sc; return sc;
} }