RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

Simple SMP Scheduler - Fix typo which likely broke scheduling

Browse Source
This commit is contained in:
Joel Sherrill
2012-04-24 16:08:16 -05:00
parent 05a20c1f79
commit 32815a2636
1 changed files with 31 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
cpukit/score/src/schedulersimplesmpschedule.c
View File

@@ -1,14 +1,16 @@
/* /**
* Scheduler Simple SMP Handler / Schedule * @file
* *
* COPYRIGHT (c) 2011. * Scheduler Simple SMP Handler / Schedule
*/
/*
* COPYRIGHT (c) 2011- 2012.
* On-Line Applications Research Corporation (OAR). * On-Line Applications Research Corporation (OAR).
* *
* The license and distribution terms for this file may be * The license and distribution terms for this file may be
* found in found in the file LICENSE in this distribution or at * found in found in the file LICENSE in this distribution or at
* http://www.rtems.com/license/LICENSE. * http://www.rtems.com/license/LICENSE.
*
* $Id$
*/ */
#if HAVE_CONFIG_H #if HAVE_CONFIG_H
@@ -36,6 +38,11 @@
#define D(format,...) #define D(format,...)
#endif #endif
/* Declaration to avoid warnings */
bool _Scheduler_simple_smp_Assign(
Thread_Control *consider
);
/** /**
* @brief Assign Heir Thread to CPU * @brief Assign Heir Thread to CPU
* *
@@ -56,7 +63,6 @@
* false, there is no point in attempting to place an heir of * false, there is no point in attempting to place an heir of
* of lower priority. * of lower priority.
*/ */
bool _Scheduler_simple_smp_Assign( bool _Scheduler_simple_smp_Assign(
Thread_Control *consider Thread_Control *consider
) )
@@ -134,7 +140,12 @@ bool _Scheduler_simple_smp_Assign(
} }
/* /*
* Past this point, found is true. * ASSERTION: (found == true)
*
* Past this point, we have found a potential heir and are considering
* whether the thread is better placed on another core. It is desirable
* to preempt the lowest priority thread using time on core and
* preemptibility as additional factors.
*/ */
/* /*
@@ -155,9 +166,21 @@ bool _Scheduler_simple_smp_Assign(
continue; continue;
} }
if ( h->current_priority > pheir->current_priority ) /*
* If the current heir is more important than the potential
* heir, then we should not consider it further in scheduling.
*/
if ( h->current_priority < pheir->current_priority )
continue; continue;
/*
* ASSERTION: (h->current_priority == pheir->current_priority).
*
* Past this point, this means we are considering the length of time
* the thread has spent on the time on the CPU core and if it is
* preemptible.
*/
/* /*
* If heir of potential CPU and of the current CPU are of the SAME * If heir of potential CPU and of the current CPU are of the SAME
* priority, then which has been running longer? * priority, then which has been running longer?