RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

+ Changed validation of the_thread to validation of location.

Browse Source 
+  Removed error path that should never happen.
This commit is contained in:
Joel Sherrill
1999-11-12 21:21:09 +00:00
parent 3971537bd2
commit 2979c288bb
2 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
c/src/exec/itron/src/sta_tsk.c
View File

@@ -31,18 +31,16 @@ ER sta_tsk(
boolean status;
the_thread = _ITRON_Task_Get( tskid, &location );
if (!the_thread)
_ITRON_return_errorno( _ITRON_Task_Clarify_get_id_error( tskid ) );
if ( !_States_Is_dormant( the_thread->current_state ) )
_ITRON_return_errorno( E_OBJ );
switch ( location ) {
case OBJECTS_REMOTE:
case OBJECTS_ERROR:
_ITRON_return_errorno( _ITRON_Task_Clarify_get_id_error( tskid ) );
case OBJECTS_LOCAL:
if ( !_States_Is_dormant( the_thread->current_state ) )
_ITRON_return_errorno( E_OBJ );
status = _Thread_Start(
the_thread,
THREAD_START_NUMERIC, /* XXX should be able to say we have no arg */
@@ -51,14 +49,16 @@ ER sta_tsk(
0 /* unused */
);
/*
* This error can not happen entry_point is checked in create.
if ( !status )
_ITRON_return_errorno( E_OBJ );
*/
_Thread_Enable_dispatch();
return E_OK;
_ITRON_return_errorno( E_OK );
}
return E_OBJ; /* unreached - only to remove warnings */
_ITRON_return_errorno( E_OBJ ); /* unreached - only to remove warnings */
}

18
cpukit/itron/src/sta_tsk.c
View File

@@ -31,18 +31,16 @@ ER sta_tsk(
boolean status;
the_thread = _ITRON_Task_Get( tskid, &location );
if (!the_thread)
_ITRON_return_errorno( _ITRON_Task_Clarify_get_id_error( tskid ) );
if ( !_States_Is_dormant( the_thread->current_state ) )
_ITRON_return_errorno( E_OBJ );
switch ( location ) {
case OBJECTS_REMOTE:
case OBJECTS_ERROR:
_ITRON_return_errorno( _ITRON_Task_Clarify_get_id_error( tskid ) );
case OBJECTS_LOCAL:
if ( !_States_Is_dormant( the_thread->current_state ) )
_ITRON_return_errorno( E_OBJ );
status = _Thread_Start(
the_thread,
THREAD_START_NUMERIC, /* XXX should be able to say we have no arg */
@@ -51,14 +49,16 @@ ER sta_tsk(
0 /* unused */
);
/*
* This error can not happen entry_point is checked in create.
if ( !status )
_ITRON_return_errorno( E_OBJ );
*/
_Thread_Enable_dispatch();
return E_OK;
_ITRON_return_errorno( E_OK );
}
return E_OBJ; /* unreached - only to remove warnings */
_ITRON_return_errorno( E_OBJ ); /* unreached - only to remove warnings */
}