RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

IMFS: Avoid NULL pointer access

Browse Source 
Avoid NULL pointer access in IMFS_is_imfs_instance().  File systems
mounted via mount() always have a valid type string.
This commit is contained in:
Sebastian Huber
2014-10-08 11:24:36 +02:00
parent b9f952254b
commit 22cd2821de
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cpukit/libcsupport/src/__usrenv.c
View File

@@ -229,7 +229,8 @@ rtems_filesystem_mount_table_entry_t rtems_filesystem_null_mt_entry = {
.mt_point_node = &rtems_filesystem_global_location_null, .mt_point_node = &rtems_filesystem_global_location_null,
.mt_fs_root = &rtems_filesystem_global_location_null, .mt_fs_root = &rtems_filesystem_global_location_null,
.mounted = false, .mounted = false,
.writeable = false .writeable = false,
.type = ""
}; };
rtems_filesystem_global_location_t rtems_filesystem_global_location_null = { rtems_filesystem_global_location_t rtems_filesystem_global_location_null = {

11
testsuites/fstests/fsimfsgeneric01/init.c
View File

@@ -472,6 +472,17 @@ static void test_imfs_make_generic_node_errors(void)
rtems_test_assert(rv == -1); rtems_test_assert(rv == -1);
rtems_test_assert(errno == EIO); rtems_test_assert(errno == EIO);
rtems_test_assert(rtems_resource_snapshot_check(&before)); rtems_test_assert(rtems_resource_snapshot_check(&before));
errno = 0;
rv = IMFS_make_generic_node(
"/nil/nada",
S_IFCHR | S_IRWXU | S_IRWXG | S_IRWXO,
&node_control,
NULL
);
rtems_test_assert(rv == -1);
rtems_test_assert(errno == ENOENT);
rtems_test_assert(rtems_resource_snapshot_check(&before));
} }
static void Init(rtems_task_argument arg) static void Init(rtems_task_argument arg)