RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

grspw.c: Fix Unchecked return value (CID #1399781)

Browse Source 
CID 1399781: Unchecked return value in grspw_device_init().

Closes #4259
This commit is contained in:
Ryan Long
2021-03-01 11:06:48 -05:00
committed by Joel Sherrill
parent 6ebf376bf2
commit 1eaf4e461f
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
bsps/shared/grlib/spw/grspw.c
View File

@@ -465,6 +465,7 @@ int grspw_device_init(GRSPW_DEV *pDev)
struct amba_dev_info *ambadev; struct amba_dev_info *ambadev;
struct ambapp_core *pnpinfo; struct ambapp_core *pnpinfo;
union drvmgr_key_value *value; union drvmgr_key_value *value;
rtems_status_code status;
/* Get device information from AMBA PnP information */ /* Get device information from AMBA PnP information */
ambadev = (struct amba_dev_info *)pDev->dev->businfo; ambadev = (struct amba_dev_info *)pDev->dev->businfo;
@@ -555,21 +556,23 @@ int grspw_device_init(GRSPW_DEV *pDev)
return RTEMS_NO_MEMORY; return RTEMS_NO_MEMORY;
/* Create semaphores */ /* Create semaphores */
rtems_semaphore_create( status = rtems_semaphore_create(
rtems_build_name('T', 'x', 'S', '0' + pDev->minor), rtems_build_name('T', 'x', 'S', '0' + pDev->minor),
0, 0,
RTEMS_FIFO | RTEMS_SIMPLE_BINARY_SEMAPHORE | RTEMS_NO_INHERIT_PRIORITY | \ RTEMS_FIFO | RTEMS_SIMPLE_BINARY_SEMAPHORE | RTEMS_NO_INHERIT_PRIORITY | \
RTEMS_NO_PRIORITY_CEILING, RTEMS_NO_PRIORITY_CEILING,
0, 0,
&(pDev->txsp)); &(pDev->txsp));
_Assert_Unused_variable_equals(status, RTEMS_SUCCESSFUL);
rtems_semaphore_create( status = rtems_semaphore_create(
rtems_build_name('R', 'x', 'S', '0' + pDev->minor), rtems_build_name('R', 'x', 'S', '0' + pDev->minor),
0, 0,
RTEMS_FIFO | RTEMS_SIMPLE_BINARY_SEMAPHORE | RTEMS_NO_INHERIT_PRIORITY | \ RTEMS_FIFO | RTEMS_SIMPLE_BINARY_SEMAPHORE | RTEMS_NO_INHERIT_PRIORITY | \
RTEMS_NO_PRIORITY_CEILING, RTEMS_NO_PRIORITY_CEILING,
0, 0,
&(pDev->rxsp)); &(pDev->rxsp));
_Assert_Unused_variable_equals(status, RTEMS_SUCCESSFUL);
grspw_hw_init(pDev); grspw_hw_init(pDev);