From 1d08df678b4fb0ffeccbfe55e2bc4f2ead0fbc03 Mon Sep 17 00:00:00 2001 From: Joel Sherrill Date: Tue, 14 Oct 2025 14:05:23 -0500 Subject: [PATCH] testsuites/*: Address missing field initializer warnings (extensions) Address missing field initializer warnings. These were rtems_extensions_table declarations with initialization. The initialization was changed to using named fields. Updates #5325. --- testsuites/libtests/cpuuse/init.c | 17 +++++----- testsuites/libtests/stackchk/system.h | 12 ++++++- .../psxtests/psxfatal_support/psxfatalimpl.h | 17 +++++----- testsuites/sptests/sp04/init.c | 17 +++++----- testsuites/sptests/sp07/init.c | 34 ++++++++++--------- testsuites/sptests/sp56/init.c | 17 +++++----- .../sptests/spfatal_support/spfatalimpl.h | 17 +++++----- 7 files changed, 74 insertions(+), 57 deletions(-) diff --git a/testsuites/libtests/cpuuse/init.c b/testsuites/libtests/cpuuse/init.c index 136fcd5242..4adfe8a96d 100644 --- a/testsuites/libtests/cpuuse/init.c +++ b/testsuites/libtests/cpuuse/init.c @@ -44,14 +44,15 @@ const char rtems_test_name[] = "CPUUSE"; rtems_extensions_table Extensions = { - NULL, /* task create user extension */ - NULL, /* task start user extension */ - NULL, /* task restart user extension */ - NULL, /* task delete user extension */ - Task_switch, /* task switch user extension */ - NULL, /* task begin user extension */ - NULL, /* task exitted user extension */ - NULL /* fatal error user extension */ + .thread_create = NULL, /* task create user extension */ + .thread_start = NULL, /* task start user extension */ + .thread_restart = NULL, /* task restart user extension */ + .thread_delete = NULL, /* task delete user extension */ + .thread_switch = Task_switch, /* task switch user extension */ + .thread_begin = NULL, /* task begin user extension */ + .thread_exitted = NULL, /* task exitted user extension */ + .fatal = NULL, /* fatal error user extension */ + .thread_terminate = NULL /* fatal error user extension */ }; rtems_task Init( diff --git a/testsuites/libtests/stackchk/system.h b/testsuites/libtests/stackchk/system.h index 8f984e07d1..addc782e5b 100644 --- a/testsuites/libtests/stackchk/system.h +++ b/testsuites/libtests/stackchk/system.h @@ -67,7 +67,17 @@ void Fatal_extension( ); #define CONFIGURE_INITIAL_EXTENSIONS \ - { NULL, NULL, NULL, NULL, NULL, NULL, NULL, Fatal_extension }, \ + { \ + .thread_create = NULL, \ + .thread_start = NULL, \ + .thread_restart = NULL, \ + .thread_delete = NULL, \ + .thread_switch = NULL, \ + .thread_begin = NULL, \ + .thread_exitted = NULL, \ + .fatal = Fatal_extension, \ + .thread_terminate = NULL \ + }, \ RTEMS_TEST_INITIAL_EXTENSION #include diff --git a/testsuites/psxtests/psxfatal_support/psxfatalimpl.h b/testsuites/psxtests/psxfatal_support/psxfatalimpl.h index 9ea549d4e5..3aba3baa43 100644 --- a/testsuites/psxtests/psxfatal_support/psxfatalimpl.h +++ b/testsuites/psxtests/psxfatal_support/psxfatalimpl.h @@ -114,14 +114,15 @@ static void Fatal_extension( #define CONFIGURE_INITIAL_EXTENSIONS \ { \ - NULL, /* create */ \ - NULL, /* start */ \ - NULL, /* restart */ \ - NULL, /* delete */ \ - NULL, /* switch */ \ - NULL, /* begin */ \ - NULL, /* exitted */ \ - Fatal_extension /* fatal */ \ + .thread_create = NULL, \ + .thread_start = NULL, \ + .thread_restart = NULL, \ + .thread_delete = NULL, \ + .thread_switch = NULL, \ + .thread_begin = NULL, \ + .thread_exitted = NULL, \ + .fatal = Fatal_extension, \ + .thread_terminate = NULL \ }, \ RTEMS_TEST_INITIAL_EXTENSION diff --git a/testsuites/sptests/sp04/init.c b/testsuites/sptests/sp04/init.c index e873aaae5c..625d5f0f7e 100644 --- a/testsuites/sptests/sp04/init.c +++ b/testsuites/sptests/sp04/init.c @@ -48,14 +48,15 @@ const char rtems_test_name[] = "SP 4"; rtems_extensions_table Extensions = { - NULL, /* task create user extension */ - NULL, /* task start user extension */ - NULL, /* task restart user extension */ - NULL, /* task delete user extension */ - Task_switch, /* task switch user extension */ - NULL, /* task begin user extension */ - NULL, /* task exitted user extension */ - NULL /* fatal error user extension */ + .thread_create = NULL, + .thread_start = NULL, + .thread_restart = NULL, + .thread_delete = NULL, + .thread_switch = Task_switch, + .thread_begin = NULL, + .thread_exitted = NULL, + .fatal = NULL, + .thread_terminate = NULL }; rtems_task Init( diff --git a/testsuites/sptests/sp07/init.c b/testsuites/sptests/sp07/init.c index b6f444b55f..d7a6bb26d6 100644 --- a/testsuites/sptests/sp07/init.c +++ b/testsuites/sptests/sp07/init.c @@ -67,25 +67,27 @@ static bool Task_harmless_extension_true_two( } static const rtems_extensions_table Harmless_extensions = { - Task_harmless_extension_true_two, - Task_harmless_extension_two, - Task_harmless_extension_two, - Task_harmless_extension_two, - Task_harmless_extension_two, - Task_harmless_extension_one, - Task_harmless_extension_one, - NULL + .thread_create = Task_harmless_extension_true_two, + .thread_start = Task_harmless_extension_two, + .thread_restart = Task_harmless_extension_two, + .thread_delete = Task_harmless_extension_two, + .thread_switch = Task_harmless_extension_two, + .thread_begin = Task_harmless_extension_one, + .thread_exitted = Task_harmless_extension_one, + .fatal = NULL, + .thread_terminate = NULL }; rtems_extensions_table Extensions = { - Task_create_extension, /* task create user extension */ - Task_start_extension, /* task start user extension */ - Task_restart_extension, /* task restart user extension */ - Task_delete_extension, /* task delete user extension */ - NULL, /* task switch user extension */ - NULL, /* begin user extension */ - Task_exit_extension, /* task exitted user extension */ - NULL /* fatal error extension */ + .thread_create = Task_create_extension, + .thread_start = Task_start_extension, + .thread_restart = Task_restart_extension, + .thread_delete = Task_delete_extension, + .thread_switch = NULL, + .thread_begin = NULL, + .thread_exitted = Task_exit_extension, + .fatal = NULL, + .thread_terminate = NULL }; rtems_task Init( diff --git a/testsuites/sptests/sp56/init.c b/testsuites/sptests/sp56/init.c index 57c3946630..89cd781fa8 100644 --- a/testsuites/sptests/sp56/init.c +++ b/testsuites/sptests/sp56/init.c @@ -56,14 +56,15 @@ bool task_create( } rtems_extensions_table Extensions = { - task_create, /* task create user extension */ - NULL, /* task start user extension */ - NULL, /* task restart user extension */ - NULL, /* task delete user extension */ - NULL, /* task switch user extension */ - NULL, /* task begin user extension */ - NULL, /* task exitted user extension */ - NULL /* fatal error user extension */ + .thread_create = task_create, + .thread_start = NULL, + .thread_restart = NULL, + .thread_delete = NULL, + .thread_switch = NULL, + .thread_begin = NULL, + .thread_exitted = NULL, + .fatal = NULL, + .thread_terminate = NULL }; rtems_task Init( diff --git a/testsuites/sptests/spfatal_support/spfatalimpl.h b/testsuites/sptests/spfatal_support/spfatalimpl.h index bccf123172..560877b45e 100644 --- a/testsuites/sptests/spfatal_support/spfatalimpl.h +++ b/testsuites/sptests/spfatal_support/spfatalimpl.h @@ -130,14 +130,15 @@ static void Fatal_extension( #define CONFIGURE_INITIAL_EXTENSIONS \ { \ - NULL, /* create */ \ - NULL, /* start */ \ - NULL, /* restart */ \ - NULL, /* delete */ \ - NULL, /* switch */ \ - NULL, /* begin */ \ - NULL, /* exitted */ \ - Fatal_extension /* fatal */ \ + .thread_create = NULL, \ + .thread_start = NULL, \ + .thread_restart = NULL, \ + .thread_delete = NULL, \ + .thread_switch = NULL, \ + .thread_begin = NULL, \ + .thread_exitted = NULL, \ + .fatal = Fatal_extension, \ + .thread_terminate = NULL \ }, \ RTEMS_TEST_INITIAL_EXTENSION