forked from Imagelibrary/littlefs
Removed concept of geometries from test/bench runners
This turned out to not be all that useful. Tests already take quite a bit to run, which is a good thing! We have a lot of tests! 942.68s or ~15 minutes of tests at the time of writing to be exact. But simply multiplying the number of tests by some number of geometries is heavy handed and not a great use of testing time. Instead, tests where different geometries are relevant can parameterize READ_SIZE/PROG_SIZE/BLOCK_SIZE at the suite level where needed. The geometry system was just another define parameterization layer anyways. Testing different geometries can still be done in CI by overriding the relevant defines anyways, and it _might_ be interesting there.
This commit is contained in:
@@ -640,8 +640,6 @@ def find_runner(runner, id=None, **args):
|
||||
'-o%s' % args['perf']]))
|
||||
|
||||
# other context
|
||||
if args.get('geometry'):
|
||||
cmd.append('-G%s' % args['geometry'])
|
||||
if args.get('disk'):
|
||||
cmd.append('-d%s' % args['disk'])
|
||||
if args.get('trace'):
|
||||
@@ -902,7 +900,6 @@ def list_(runner, bench_ids=[], **args):
|
||||
cmd.append('--list-permutation-defines')
|
||||
if args.get('list_implicit_defines'):
|
||||
cmd.append('--list-implicit-defines')
|
||||
if args.get('list_geometries'): cmd.append('--list-geometries')
|
||||
|
||||
if args.get('verbose'):
|
||||
print(' '.join(shlex.quote(c) for c in cmd))
|
||||
@@ -1439,8 +1436,7 @@ def main(**args):
|
||||
or args.get('list_case_paths')
|
||||
or args.get('list_defines')
|
||||
or args.get('list_permutation_defines')
|
||||
or args.get('list_implicit_defines')
|
||||
or args.get('list_geometries')):
|
||||
or args.get('list_implicit_defines')):
|
||||
return list_(**args)
|
||||
else:
|
||||
return run(**args)
|
||||
@@ -1508,17 +1504,10 @@ if __name__ == "__main__":
|
||||
'--list-implicit-defines',
|
||||
action='store_true',
|
||||
help="List implicit defines in this bench-runner.")
|
||||
bench_parser.add_argument(
|
||||
'--list-geometries',
|
||||
action='store_true',
|
||||
help="List the available disk geometries.")
|
||||
bench_parser.add_argument(
|
||||
'-D', '--define',
|
||||
action='append',
|
||||
help="Override a bench define.")
|
||||
bench_parser.add_argument(
|
||||
'-G', '--geometry',
|
||||
help="Comma-separated list of disk geometries to bench.")
|
||||
bench_parser.add_argument(
|
||||
'-d', '--disk',
|
||||
help="Direct block device operations to this file.")
|
||||
|
||||
Reference in New Issue
Block a user