Dropped --github from plotmpl.py

- Not as easy to read as --ggplot, the light shades are maybe poorly
  suited for plots vs other larger block elements on GitHub. I don't
  know, I'm not really a graphic designer.

- GitHub may be a moving target in the future.

- GitHub is already a moving target because it has like 9 different
  optional color schemes (which is good!), so most of the time the
  colors won't match anyways.

- The neutral gray of --ggplot works just as well outside of GitHub.

Worst case, --github was just a preset color palette, so it could in
theory be emulated with --foreground + --background + --font-color.
This commit is contained in:
Christopher Haster
2023-11-06 20:26:26 -06:00
parent 6f0e0c918d
commit d36d67c9b0

View File

@@ -592,7 +592,6 @@ def main(csv_paths, output, *,
dark=False,
ggplot=False,
xkcd=False,
github=False,
font=None,
font_size=FONT_SIZE,
font_color=None,
@@ -608,25 +607,6 @@ def main(csv_paths, output, *,
else:
svg = True
# some shortcuts for color schemes
if github:
ggplot = True
if font_color is None:
if dark:
font_color = '#e6edf3'
else:
font_color = '#1f2328'
if foreground is None:
if dark:
foreground = '#1f242c'
else:
foreground = '#eaeef2'
if background is None:
if dark:
background = '#0d1117'
else:
background = '#ffffff'
# what colors/alphas/formats to use?
if colors is not None:
colors_ = colors
@@ -1284,10 +1264,6 @@ if __name__ == "__main__":
'--xkcd',
action='store_true',
help="Use the xkcd style.")
parser.add_argument(
'--github',
action='store_true',
help="Use the ggplot style with GitHub colors.")
parser.add_argument(
'--font',
type=lambda x: [x.strip() for x in x.split(',')],