MagnitudeOS/littlefs
1
0
Fork 0
forked from Imagelibrary/littlefs
Code Pull Requests Activity

Stop wear-leveling during migration

Browse Source 
Stop proactively relocate blocks during migrations, this can cause a number of
failure states such: clobbering the v1 superblock if we relocate root, and
invalidating directory pointers if we relocate the head of a directory. On top
of this, relocations increase the overall complexity of lfs_migration, which is
already a delicate operation.
This commit is contained in:
Christopher Haster
2019-11-26 13:59:45 -06:00
parent aae22c8256
commit aeff2a28cf
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lfs.c
View File

@@ -1503,9 +1503,13 @@ static int lfs_dir_compact(lfs_t *lfs,
} }
} }
#ifdef LFS_MIGRATE #ifdef LFS_MIGRATE
} else if (lfs_pair_cmp(dir->pair, lfs->root) == 0 && lfs->lfs1) { } else if (lfs->lfs1) {
// we can't relocate our root during migrations, as this would // do not proactively relocate blocks during migrations, this
// cause the superblock to get updated, which would clobber v1 // can cause a number of failure states such: clobbering the
// v1 superblock if we relocate root, and invalidating directory
// pointers if we relocate the head of a directory. On top of
// this, relocations increase the overall complexity of
// lfs_migration, which is already a delicate operation.
#endif #endif
} else { } else {
// we're writing too much, time to relocate // we're writing too much, time to relocate