From b19b468e13be46874fba1e946cfb4b6a33481ecb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Desbiens?= Date: Thu, 17 Jul 2025 16:26:04 -0400 Subject: [PATCH 1/5] Added workflow permissions. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Frédéric Desbiens --- .github/workflows/regression_test.yml | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/.github/workflows/regression_test.yml b/.github/workflows/regression_test.yml index 636f089c..c55a2c56 100644 --- a/.github/workflows/regression_test.yml +++ b/.github/workflows/regression_test.yml @@ -12,6 +12,13 @@ on: # A workflow run is made up of one or more jobs that can run sequentially or in parallel jobs: tx: + permissions: + contents: read + issues: read + checks: write + pull-requests: write + pages: write + id-token: write uses: ./.github/workflows/regression_template.yml with: build_script: ./scripts/build_tx.sh @@ -20,6 +27,13 @@ jobs: result_affix: ThreadX skip_deploy: true smp: + permissions: + contents: read + issues: read + checks: write + pull-requests: write + pages: write + id-token: write uses: ./.github/workflows/regression_template.yml with: build_script: ./scripts/build_smp.sh @@ -28,6 +42,13 @@ jobs: result_affix: SMP skip_deploy: true deploy: + permissions: + contents: read + issues: read + checks: write + pull-requests: write + pages: write + id-token: write needs: [tx, smp] uses: ./.github/workflows/regression_template.yml with: From 754c3485687346f0f83d1d06893dc85662c96b28 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Desbiens?= Date: Thu, 17 Jul 2025 19:51:12 -0400 Subject: [PATCH 2/5] Updated all actions to their latest release. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Frédéric Desbiens --- .github/workflows/regression_template.yml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/regression_template.yml b/.github/workflows/regression_template.yml index 5e292921..6febb5c0 100644 --- a/.github/workflows/regression_template.yml +++ b/.github/workflows/regression_template.yml @@ -63,7 +63,7 @@ jobs: # Steps represent a sequence of tasks that will be executed as part of the job steps: - name: Check out the repository - uses: actions/checkout@v4 + uses: actions/checkout@v4.2.2 with: submodules: true @@ -86,7 +86,7 @@ jobs: - name: Upload Test Results if: success() || failure() - uses: actions/upload-artifact@v4.6.0 + uses: actions/upload-artifact@v4.6.2 with: name: test_reports ${{ inputs.result_affix }} path: | @@ -95,7 +95,7 @@ jobs: ${{ inputs.cmake_path }}/build/**/regression/output_files/*.bin - name: Configure GitHub Pages - uses: actions/configure-pages@v3.0.6 + uses: actions/configure-pages@v5.0.0 - name: Generate Code Coverage Results Summary if: (!inputs.skip_coverage) @@ -115,7 +115,7 @@ jobs: - name: Create CheckRun for Code Coverage if: ((github.event_name == 'push') || (github.event_name == 'workflow_dispatch') || (github.event.pull_request.head.repo.full_name == github.repository)) && (!inputs.skip_coverage) - uses: LouisBrunner/checks-action@v1.6.2 + uses: LouisBrunner/checks-action@v2.0.0 with: token: ${{ secrets.GITHUB_TOKEN }} name: Code Coverage ${{ inputs.result_affix }} @@ -126,7 +126,7 @@ jobs: - name: Add Code Coverage PR Comment if: ((github.event_name == 'push') || (github.event.pull_request.head.repo.full_name == github.repository)) && (!inputs.skip_coverage) - uses: marocchino/sticky-pull-request-comment@v2 + uses: marocchino/sticky-pull-request-comment@v2.9.4 with: header: Code Coverage ${{ inputs.result_affix }} path: code-coverage-results.md @@ -141,7 +141,7 @@ jobs: fi - name: Upload Code Coverage Artifacts - uses: actions/upload-artifact@v4.6.0 + uses: actions/upload-artifact@v4.6.2 if: (inputs.skip_deploy && !inputs.skip_coverage) with: name: coverage_report @@ -149,7 +149,7 @@ jobs: retention-days: 1 - name: Upload Code Coverage Pages - uses: actions/upload-pages-artifact@v2.0.0 + uses: actions/upload-pages-artifact@v3.0.1 if: (!inputs.skip_deploy && !inputs.skip_coverage) with: path: ${{ inputs.cmake_path }}/coverage_report/${{ inputs.coverage_name }} @@ -166,25 +166,25 @@ jobs: id-token: write steps: - - uses: actions/download-artifact@v4.1.7 + - uses: actions/download-artifact@v4.3.0 if: ${{ inputs.skip_test }} with: name: coverage_report - name: Upload Code Coverage Pages - uses: actions/upload-pages-artifact@v2.0.0 + uses: actions/upload-pages-artifact@v3.0.1 if: ${{ inputs.skip_test }} with: path: . - name: Delete Duplicate Code Coverage Artifact - uses: geekyeggo/delete-artifact@v2 + uses: geekyeggo/delete-artifact@v5.1.0 with: name: coverage_report - name: Deploy GitHub Pages site id: deployment - uses: actions/deploy-pages@v1.2.9 + uses: actions/deploy-pages@v4.0.5 - name: Write Code Coverage Report URL run: >- From c00056bb7827f6aeeaad61f82aed7e4a362dc99f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Desbiens?= Date: Tue, 29 Jul 2025 16:23:08 -0400 Subject: [PATCH 3/5] Fixed code coverage artefacts upload --- .github/workflows/regression_template.yml | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/.github/workflows/regression_template.yml b/.github/workflows/regression_template.yml index 6febb5c0..7b9f8209 100644 --- a/.github/workflows/regression_template.yml +++ b/.github/workflows/regression_template.yml @@ -139,15 +139,19 @@ jobs: sudo mv ${{ inputs.cmake_path }}/coverage_report/${{ inputs.coverage_name }} \ ${{ inputs.cmake_path }}/coverage_report/${{ inputs.result_affix }} fi - + + - name: Coverage Report name + id: artifact + run: echo "coverage_report=coverage_report-$(date +%s)" >> $GITHUB_OUTPUT + - name: Upload Code Coverage Artifacts - uses: actions/upload-artifact@v4.6.2 - if: (inputs.skip_deploy && !inputs.skip_coverage) - with: - name: coverage_report - path: ${{ inputs.cmake_path }}/coverage_report - retention-days: 1 - + uses: actions/upload-artifact@v4.6.2 + if: (inputs.skip_deploy && !inputs.skip_coverage) + with: + name: ${{ steps.artifact.outputs.coverage_report }} + path: ${{ inputs.cmake_path }}/coverage_report + retention-days: 1 + - name: Upload Code Coverage Pages uses: actions/upload-pages-artifact@v3.0.1 if: (!inputs.skip_deploy && !inputs.skip_coverage) From 8e808e70f1d530d1196644d712f473a23ca06366 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Desbiens?= Date: Tue, 29 Jul 2025 16:46:45 -0400 Subject: [PATCH 4/5] Added condition to "Coverage Report Name". Corrected formatting. --- .github/workflows/regression_template.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/regression_template.yml b/.github/workflows/regression_template.yml index 7b9f8209..e8ef195b 100644 --- a/.github/workflows/regression_template.yml +++ b/.github/workflows/regression_template.yml @@ -141,13 +141,14 @@ jobs: fi - name: Coverage Report name - id: artifact - run: echo "coverage_report=coverage_report-$(date +%s)" >> $GITHUB_OUTPUT + id: artifact + if: (!inputs.skip_coverage) + run: echo "coverage_report=coverage_report-$(date +%s)" >> $GITHUB_OUTPUT - name: Upload Code Coverage Artifacts - uses: actions/upload-artifact@v4.6.2 - if: (inputs.skip_deploy && !inputs.skip_coverage) - with: + uses: actions/upload-artifact@v4.6.2 + if: (inputs.skip_deploy && !inputs.skip_coverage) + with: name: ${{ steps.artifact.outputs.coverage_report }} path: ${{ inputs.cmake_path }}/coverage_report retention-days: 1 From 8616486d99e74dd801d8c9939b841651dddb2187 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Desbiens?= Date: Tue, 29 Jul 2025 17:05:07 -0400 Subject: [PATCH 5/5] Fixed code coverage report download step in deploy_code_coverage. --- .github/workflows/regression_template.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/regression_template.yml b/.github/workflows/regression_template.yml index e8ef195b..f2b529f6 100644 --- a/.github/workflows/regression_template.yml +++ b/.github/workflows/regression_template.yml @@ -174,7 +174,8 @@ jobs: - uses: actions/download-artifact@v4.3.0 if: ${{ inputs.skip_test }} with: - name: coverage_report + name: ${{ steps.artifact.outputs.coverage_report }} + path: ${{ inputs.cmake_path }}/coverage_report - name: Upload Code Coverage Pages uses: actions/upload-pages-artifact@v3.0.1