From f6e7b3bfbf0b57e67bd67c1b3eafe65cc777d66b Mon Sep 17 00:00:00 2001
From: Joel Sherrill <joel@rtems.org>
Date: Sun, 12 Oct 2025 10:45:24 -0500
Subject: [PATCH] bsps/powerpc: Address missing field initializer warnings

Address missing field initializer warnings.

These were all rtems_irq_connect_data declarations with initialization.
The initialization was changed to using named fields and specifying an
initializer for each field.
---
 bsps/powerpc/mpc8260ads/include/tm27.h | 11 ++++++-----
 bsps/powerpc/mvme3100/irq/irq_init.c   |  9 +++++++--
 bsps/powerpc/psim/include/tm27.h       | 13 +++++++------
 bsps/powerpc/psim/irq/irq_init.c       |  9 +++++++--
 bsps/powerpc/shared/clock/p_clock.c    | 13 +++++++------
 bsps/powerpc/ss555/start/tm27supp.c    | 12 ++++++------
 6 files changed, 40 insertions(+), 27 deletions(-)

diff --git a/bsps/powerpc/mpc8260ads/include/tm27.h b/bsps/powerpc/mpc8260ads/include/tm27.h
index 7d09532e77..139db331de 100644
--- a/bsps/powerpc/mpc8260ads/include/tm27.h
+++ b/bsps/powerpc/mpc8260ads/include/tm27.h
@@ -30,11 +30,12 @@
 #define Install_tm27_vector( handler ) \
    do { \
 	static rtems_irq_connect_data scIrqData = { \
-	  PPC_IRQ_SCALL, \
-	  handler, \
-	  NULL, \
-	  NULL, \
-	  NULL  \
+	  .name = PPC_IRQ_SCALL, \
+	  .hdl = handler, \
+	  .handle = NULL, \
+	  .on = NULL, \
+	  .off = NULL, \
+	  .isOn = NULL \
 	}; \
 	BSP_install_rtems_irq_handler (&scIrqData); \
    } while(0)
diff --git a/bsps/powerpc/mvme3100/irq/irq_init.c b/bsps/powerpc/mvme3100/irq/irq_init.c
index 1d20c0fbd0..0ef65c9a9f 100644
--- a/bsps/powerpc/mvme3100/irq/irq_init.c
+++ b/bsps/powerpc/mvme3100/irq/irq_init.c
@@ -38,8 +38,13 @@ static void nop_func(void *unused)
 static rtems_irq_connect_data     	rtemsIrq[BSP_IRQ_NUMBER];
 static rtems_irq_global_settings    initial_config;
 static rtems_irq_connect_data     	defaultIrq = {
-  /* vectorIdex,	 hdl		, handle	, on		, off		, isOn */
-  0, 			 nop_func	, NULL		, 0	, 0	, 0
+	.name = 0,
+	.hdl = nop_func,
+	.handle = NULL,
+	.on = NULL,
+	.off = NULL,
+	.isOn = NULL,
+	.next_handler = NULL
 };
 
 static rtems_irq_prio irqPrioTable[BSP_IRQ_NUMBER]={
diff --git a/bsps/powerpc/psim/include/tm27.h b/bsps/powerpc/psim/include/tm27.h
index 84204f17ea..cff1976e68 100644
--- a/bsps/powerpc/psim/include/tm27.h
+++ b/bsps/powerpc/psim/include/tm27.h
@@ -46,12 +46,13 @@ static int stub_rtems_irq_is_enabled(
 }
 
 static rtems_irq_connect_data clockIrqData = {
-  BSP_DECREMENTER,
-  0,
-  0,
-  stub_rtems_irq_enable,
-  stub_rtems_irq_disable,
-  stub_rtems_irq_is_enabled
+  .name = BSP_DECREMENTER,
+  .hdl = 0,
+  .handle = 0,
+  .on = stub_rtems_irq_enable,
+  .off = stub_rtems_irq_disable,
+  .isOn = stub_rtems_irq_is_enabled,
+  .next_handler = NULL
 };
 
 static inline void Install_tm27_vector( rtems_interrupt_handler handler )
diff --git a/bsps/powerpc/psim/irq/irq_init.c b/bsps/powerpc/psim/irq/irq_init.c
index 49daa37edc..386e18e7d0 100644
--- a/bsps/powerpc/psim/irq/irq_init.c
+++ b/bsps/powerpc/psim/irq/irq_init.c
@@ -29,8 +29,13 @@
 static rtems_irq_connect_data      rtemsIrq[BSP_IRQ_NUMBER];
 static rtems_irq_global_settings   initial_config;
 static rtems_irq_connect_data      defaultIrq = {
-  /* vectorIdex, hdl  , handle  , on  , off , isOn */
-      0,          NULL, NULL    , NULL, NULL, NULL
+  .name = 0,
+  .hdl = NULL,
+  .handle = NULL,
+  .on = NULL,
+  .off = NULL,
+  .isOn = NULL,
+  .next_handler = NULL
 };
 static rtems_irq_prio irqPrioTable[BSP_IRQ_NUMBER]={
   /*
diff --git a/bsps/powerpc/shared/clock/p_clock.c b/bsps/powerpc/shared/clock/p_clock.c
index ba156c7600..13908347aa 100644
--- a/bsps/powerpc/shared/clock/p_clock.c
+++ b/bsps/powerpc/shared/clock/p_clock.c
@@ -23,12 +23,13 @@
 
 static rtems_irq_connect_data clockIrqData;
 static rtems_irq_connect_data clockIrqData = {
-  BSP_DECREMENTER,
-  clockIsr,
-  NULL,
-  (rtems_irq_enable)clockOn,
-  (rtems_irq_disable)clockOff,
-  (rtems_irq_is_enabled) clockIsOn
+  .name = BSP_DECREMENTER,
+  .hdl = clockIsr,
+  .handle = NULL,
+  .on = (rtems_irq_enable)clockOn,
+  .off = (rtems_irq_disable)clockOff,
+  .isOn = (rtems_irq_is_enabled) clockIsOn,
+  .next_handler = NULL
 };
 
 int BSP_disconnect_clock_handler(void)
diff --git a/bsps/powerpc/ss555/start/tm27supp.c b/bsps/powerpc/ss555/start/tm27supp.c
index 4c1660ff70..5785429cbd 100644
--- a/bsps/powerpc/ss555/start/tm27supp.c
+++ b/bsps/powerpc/ss555/start/tm27supp.c
@@ -5,10 +5,10 @@
 #include <bsp.h>
 
 rtems_irq_connect_data tm27IrqData = {
-  CPU_USIU_EXT_IRQ_7,
-  (rtems_irq_hdl)0,
-  NULL,
-  NULL,
-  NULL
+  .name = CPU_USIU_EXT_IRQ_7,
+  .hdl = 0,
+  .handle = NULL,
+  .on = NULL,
+  .off = NULL,
+  .isOn = NULL
 };
-