From 939d18ba4e41f08334e2f28eb514b2a6612b0197 Mon Sep 17 00:00:00 2001 From: Joel Sherrill Date: Wed, 28 Jan 2026 10:36:30 -0600 Subject: [PATCH] cpukit/libcrypt: Address -Wsign-compare warnings This warning occurs when comparing a signed variable to an unsigned one. This is frequently an int or ssize_t variable compared to a uint32_t or size_t. Sometimes the size_t is from a sizeof() use. --- cpukit/libcrypt/crypt-sha256.c | 4 ++++ cpukit/libcrypt/crypt-sha512.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/cpukit/libcrypt/crypt-sha256.c b/cpukit/libcrypt/crypt-sha256.c index 24373680f7..3a636db4de 100644 --- a/cpukit/libcrypt/crypt-sha256.c +++ b/cpukit/libcrypt/crypt-sha256.c @@ -165,7 +165,11 @@ crypt_sha256_r(const char *key, const char *salt, struct crypt_data *data) SHA256_Init(&alt_ctx); /* For every character in the password add the entire password. */ +#ifdef __rtems__ + for (cnt = 0; cnt < (size_t) (16 + alt_result[0]); ++cnt) +#else for (cnt = 0; cnt < 16 + alt_result[0]; ++cnt) +#endif SHA256_Update(&alt_ctx, salt, salt_len); /* Finish the digest. */ diff --git a/cpukit/libcrypt/crypt-sha512.c b/cpukit/libcrypt/crypt-sha512.c index da8acd7790..877aed1a7e 100644 --- a/cpukit/libcrypt/crypt-sha512.c +++ b/cpukit/libcrypt/crypt-sha512.c @@ -165,7 +165,11 @@ crypt_sha512_r(const char *key, const char *salt, struct crypt_data *data) SHA512_Init(&alt_ctx); /* For every character in the password add the entire password. */ +#ifdef __rtems__ + for (cnt = 0; cnt < (size_t) (16 + alt_result[0]); ++cnt) +#else for (cnt = 0; cnt < 16 + alt_result[0]; ++cnt) +#endif SHA512_Update(&alt_ctx, salt, salt_len); /* Finish the digest. */