Imagelibrary/rtems
1
0
Fork 1
mirror of https://gitlab.rtems.org/rtems/rtos/rtems.git synced 2025-12-24 21:37:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

2010-01-18 Joel Sherrill <joel.sherrill@oarcorp.com>

Browse Source 
Coverity Id 12
	Coverity Id 13
	Coverity Id 14
	Coverity Id 15
	* libmisc/stackchk/check.c: Rewrote loop to avoid possible buffer
	overruns when the pattern area size is not a multiple of 16.  There
	were no current ports impacted by this but better to be safe.
This commit is contained in:
Joel Sherrill
2010-01-18 23:04:09 +00:00
parent 8c29e98ddf
commit 2bac948920
2 changed files with 22 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
cpukit/ChangeLog
View File

@@ -1,7 +1,18 @@
2010-01-18 Joel Sherrill <joel.sherrill@oarcorp.com> 2010-01-18 Joel Sherrill <joel.sherrill@oarcorp.com>
* libfs/src/imfs/imfs_symlink.c: Add comment on Coverity CID22. This is Coverity Id 12
not a resource leak. Coverity Id 13
Coverity Id 14
Coverity Id 15
* libmisc/stackchk/check.c: Rewrote loop to avoid possible buffer
overruns when the pattern area size is not a multiple of 16. There
were no current ports impacted by this but better to be safe.
2010-01-18 Joel Sherrill <joel.sherrill@oarcorp.com>
Coverity Id 22
* libfs/src/imfs/imfs_symlink.c: Add comment to explain why this
is not a resource leak.
2010-01-18 Joel Sherrill <joel.sherrill@oarcorp.com> 2010-01-18 Joel Sherrill <joel.sherrill@oarcorp.com>

19
cpukit/libmisc/stackchk/check.c
View File

@@ -6,7 +6,7 @@
* CPU grows up or down and installs the correct * CPU grows up or down and installs the correct
* extension routines for that direction. * extension routines for that direction.
* *
* COPYRIGHT (c) 1989-2007. * COPYRIGHT (c) 1989-2009.
* On-Line Applications Research Corporation (OAR). * On-Line Applications Research Corporation (OAR).
* *
* The license and distribution terms for this file may be * The license and distribution terms for this file may be
@@ -135,7 +135,12 @@ Stack_Control Stack_check_Interrupt_stack;
*/ */
void Stack_check_Initialize( void ) void Stack_check_Initialize( void )
{ {
int i;
uint32_t *p; uint32_t *p;
static pattern[ 4 ] = {
0xFEEDF00D, 0x0BAD0D06, /* FEED FOOD to BAD DOG */
0xDEADF00D, 0x600D0D06 /* DEAD FOOD but GOOD DOG */
};
if (Stack_check_Initialized) if (Stack_check_Initialized)
return; return;
@@ -143,15 +148,9 @@ void Stack_check_Initialize( void )
/* /*
* Dope the pattern and fill areas * Dope the pattern and fill areas
*/ */
p = Stack_check_Pattern.pattern;
for ( p = Stack_check_Pattern.pattern; for ( i = 0; i < PATTERN_SIZE_WORDS; i++ ) {
p < &Stack_check_Pattern.pattern[PATTERN_SIZE_WORDS]; p[i] = pattern[ i%4 ];
p += 4
) {
p[0] = 0xFEEDF00D; /* FEED FOOD to BAD DOG */
p[1] = 0x0BAD0D06;
p[2] = 0xDEADF00D; /* DEAD FOOD GOOD DOG */
p[3] = 0x600D0D06;
} }
/* /*