From 0b7eb103fe048f66b4b7067c6cc90cb0124da3d9 Mon Sep 17 00:00:00 2001 From: Joel Sherrill Date: Fri, 30 Jan 2026 09:16:56 -0600 Subject: [PATCH] cpukit/dev: Address -Wsign-compare warnings This warning occurs when comparing a signed variable to an unsigned one. This addresses warnings that only occurred on 64-bit targets. For the ones which only appeared on 64-bit targets, the cause was frequently a mismatch when comparing a combination off_t, ssize_t, and int. --- cpukit/dev/flash/flashdev.c | 4 ++-- cpukit/dev/i2c/eeprom.c | 4 ++-- cpukit/dev/i2c/fpga-i2c-slave.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c index 4f00a17cdc..e6db844554 100644 --- a/cpukit/dev/flash/flashdev.c +++ b/cpukit/dev/flash/flashdev.c @@ -328,7 +328,7 @@ static int rtems_flashdev_check_offset_region( ) { if ( ( rtems_flashdev_is_region_defined( iop ) ) && - ( offset > rtems_flashdev_get_region_size( flash, iop ) ) ) { + ( offset > (int64_t) rtems_flashdev_get_region_size( flash, iop ) ) ) { rtems_set_errno_and_return_minus_one( EINVAL ); } return 0; @@ -506,7 +506,7 @@ static off_t rtems_flashdev_lseek( } if ( ( rtems_flashdev_is_region_defined(iop) ) && - ( tmp_offset > rtems_flashdev_get_region_size( flash, iop ) ) ) { + ( tmp_offset > (int64_t) rtems_flashdev_get_region_size( flash, iop ) ) ) { rtems_set_errno_and_return_minus_one( EINVAL ); } diff --git a/cpukit/dev/i2c/eeprom.c b/cpukit/dev/i2c/eeprom.c index 7b8f81a311..839d465e46 100644 --- a/cpukit/dev/i2c/eeprom.c +++ b/cpukit/dev/i2c/eeprom.c @@ -92,7 +92,7 @@ static ssize_t eeprom_read( return 0; } - if (n > avail) { + if (n > (size_t) avail) { n = (size_t) avail; } @@ -154,7 +154,7 @@ static ssize_t eeprom_write( return 0; } - if (n > avail) { + if (n > (size_t) avail) { n = (size_t) avail; } diff --git a/cpukit/dev/i2c/fpga-i2c-slave.c b/cpukit/dev/i2c/fpga-i2c-slave.c index 9bad862366..42caa1a151 100644 --- a/cpukit/dev/i2c/fpga-i2c-slave.c +++ b/cpukit/dev/i2c/fpga-i2c-slave.c @@ -55,7 +55,7 @@ fpga_i2c_slave_read(i2c_dev* base, void* buf, size_t n, off_t offset) return 0; } - if (n > avail) { + if ((int64_t)n > avail) { n = (size_t) avail; } @@ -97,7 +97,7 @@ fpga_i2c_slave_write(i2c_dev* base, const void* buf, size_t n, off_t offset) return 0; } - if (n > avail) { + if ((int64_t)n > avail) { n = (size_t) avail; }