Merge pull request #884 from DvdGiessen/static-functions

lfs_fs_raw* functions should be static
Added -Wmissing-prototypes
2025-11-16 12:34:34 +00:00 · 2023-10-31 13:26:35 -05:00 · 2023-10-24 12:04:54 -05:00 · 2023-10-23 13:35:34 +02:00 · 2023-09-22 11:52:21 -05:00 · 2023-09-21 13:02:09 -05:00
3 changed files with 6 additions and 3 deletions
--- a/3
+++ b/3
@@ -63,6 +63,7 @@ CFLAGS += -fcallgraph-info=su
 CFLAGS += -g3
 CFLAGS += -I.
 CFLAGS += -std=c99 -Wall -Wextra -pedantic
+CFLAGS += -Wmissing-prototypes
 CFLAGS += -ftrack-macro-expansion=0
 ifdef DEBUG
 CFLAGS += -O0
@@ -354,6 +355,7 @@ summary-diff sizes-diff: $(OBJ) $(CI)

 ## Build the test-runner
 .PHONY: test-runner build-test
+test-runner build-test: CFLAGS+=-Wno-missing-prototypes
 ifndef NO_COV
 test-runner build-test: CFLAGS+=--coverage
 endif
@@ -405,6 +407,7 @@ testmarks-diff: $(TEST_CSV)

 ## Build the bench-runner
 .PHONY: bench-runner build-bench
+bench-runner build-bench: CFLAGS+=-Wno-missing-prototypes
 ifdef YES_COV
 bench-runner build-bench: CFLAGS+=--coverage
 endif
--- a/lfs.c
+++ b/lfs.c
@@ -4999,7 +4999,7 @@ static int lfs_fs_forceconsistency(lfs_t *lfs) {
 #endif

 #ifndef LFS_READONLY
-int lfs_fs_rawmkconsistent(lfs_t *lfs) {
+static int lfs_fs_rawmkconsistent(lfs_t *lfs) {
    // lfs_fs_forceconsistency does most of the work here
    int err = lfs_fs_forceconsistency(lfs);
    if (err) {
@@ -5046,7 +5046,7 @@ static lfs_ssize_t lfs_fs_rawsize(lfs_t *lfs) {
 }

 #ifndef LFS_READONLY
-int lfs_fs_rawgrow(lfs_t *lfs, lfs_size_t block_count) {
+static int lfs_fs_rawgrow(lfs_t *lfs, lfs_size_t block_count) {
    // shrinking is not supported
    LFS_ASSERT(block_count >= lfs->block_count);

--- a/lfs.h
+++ b/lfs.h
@@ -21,7 +21,7 @@ extern "C"
 // Software library version
 // Major (top-nibble), incremented on backwards incompatible changes
 // Minor (bottom-nibble), incremented on feature additions
-#define LFS_VERSION 0x00020007
+#define LFS_VERSION 0x00020008
 #define LFS_VERSION_MAJOR (0xffff & (LFS_VERSION >> 16))
 #define LFS_VERSION_MINOR (0xffff & (LFS_VERSION >>  0))
Author	SHA1	Message	Date
Christopher Haster	c733d9ec57	Merge pull request #884 from DvdGiessen/static-functions lfs_fs_raw* functions should be static	2023-10-31 13:26:35 -05:00
Christopher Haster	8f3f32d1f3	Added -Wmissing-prototypes This warning is useful for catching the easy mistake of missing the keyword static on functions intended to be internal-only. Missing the static keyword risks symbol polution and misses potential compiler optimizations. This is an interesting warning, while useful for libraries such as littlefs, it's perfectly valid C to not predeclare all functions, and common in final application binaries. Relatedly, this warning is re-disabled for the test/bench runner. There may be a better way to organize the CFLAGS, maybe into separate LIB/RUNNER CFLAGS, but I'll leave this to future work if our CFLAGS grow more complicated. This was motivated by non-static internal-only functions leaking into a release. Found and fixed by DvdGiessen.	2023-10-24 12:04:54 -05:00
Daniël van de Giessen	92fc780f71	lfs_fs_raw* functions should be static	2023-10-23 13:35:34 +02:00
Christopher Haster	f77214d1f0	Merge pull request #877 from littlefs-project/devel Minor release: v2.8	2023-09-22 11:52:21 -05:00
Christopher Haster	f91c5bd687	Bumped minor version to v2.8	2023-09-21 13:02:09 -05:00
Christopher Haster	0eb52a2df1	Merge pull request #875 from littlefs-project/fs-gc Add lfs_fs_gc to enable proactive finding of free blocks	2023-09-21 13:01:19 -05:00