mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-12-05 15:15:42 +00:00
8480a37e14
We currently pass frames to function by value, as `frame_info_ptr`.
This is somewhat expensive:
- the size of `frame_info_ptr` is 64 bytes, which is a bit big to pass
by value
- the constructors and destructor link/unlink the object in the global
`frame_info_ptr::frame_list` list. This is an `intrusive_list`, so
it's not so bad: it's just assigning a few points, there's no memory
allocation as if it was `std::list`, but still it's useless to do
that over and over.
As suggested by Tom Tromey, change many function signatures to accept
`const frame_info_ptr &` instead of `frame_info_ptr`.
Some functions reassign their `frame_info_ptr` parameter, like:
void
the_func (frame_info_ptr frame)
{
for (; frame != nullptr; frame = get_prev_frame (frame))
{
...
}
}
I wondered what to do about them, do I leave them as-is or change them
(and need to introduce a separate local variable that can be
re-assigned). I opted for the later for consistency. It might not be
clear why some functions take `const frame_info_ptr &` while others take
`frame_info_ptr`. Also, if a function took a `frame_info_ptr` because
it did re-assign its parameter, I doubt that we would think to change it
to `const frame_info_ptr &` should the implementation change such that
it doesn't need to take `frame_info_ptr` anymore. It seems better to
have a simple rule and apply it everywhere.
Change-Id: I59d10addef687d157f82ccf4d54f5dde9a963fd0
Approved-By: Andrew Burgess <aburgess@redhat.com>
109 lines
3.8 KiB
C
109 lines
3.8 KiB
C
/* Builtin frame register, for GDB, the GNU debugger.
|
|
|
|
Copyright (C) 2002-2024 Free Software Foundation, Inc.
|
|
|
|
Contributed by Red Hat.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "user-regs.h"
|
|
#include "frame.h"
|
|
#include "gdbtypes.h"
|
|
#include "value.h"
|
|
#include "gdbarch.h"
|
|
|
|
static struct value *
|
|
value_of_builtin_frame_fp_reg (const frame_info_ptr &frame, const void *baton)
|
|
{
|
|
struct gdbarch *gdbarch = get_frame_arch (frame);
|
|
|
|
if (gdbarch_deprecated_fp_regnum (gdbarch) >= 0)
|
|
/* NOTE: cagney/2003-04-24: Since the mere presence of "fp" in the
|
|
register name table overrides this built-in $fp register, there
|
|
is no real reason for this gdbarch_deprecated_fp_regnum trickery here.
|
|
An architecture wanting to implement "$fp" as alias for a raw
|
|
register can do so by adding "fp" to register name table (mind
|
|
you, doing this is probably a dangerous thing). */
|
|
return value_of_register (gdbarch_deprecated_fp_regnum (gdbarch),
|
|
get_next_frame_sentinel_okay (frame));
|
|
else
|
|
{
|
|
struct type *data_ptr_type = builtin_type (gdbarch)->builtin_data_ptr;
|
|
struct value *val = value::allocate (data_ptr_type);
|
|
gdb_byte *buf = val->contents_raw ().data ();
|
|
|
|
gdbarch_address_to_pointer (gdbarch, data_ptr_type,
|
|
buf, get_frame_base_address (frame));
|
|
return val;
|
|
}
|
|
}
|
|
|
|
static struct value *
|
|
value_of_builtin_frame_pc_reg (const frame_info_ptr &frame, const void *baton)
|
|
{
|
|
struct gdbarch *gdbarch = get_frame_arch (frame);
|
|
|
|
if (gdbarch_pc_regnum (gdbarch) >= 0)
|
|
return value_of_register (gdbarch_pc_regnum (gdbarch),
|
|
get_next_frame_sentinel_okay (frame));
|
|
else
|
|
{
|
|
struct type *func_ptr_type = builtin_type (gdbarch)->builtin_func_ptr;
|
|
struct value *val = value::allocate (func_ptr_type);
|
|
gdb_byte *buf = val->contents_raw ().data ();
|
|
|
|
gdbarch_address_to_pointer (gdbarch, func_ptr_type,
|
|
buf, get_frame_pc (frame));
|
|
return val;
|
|
}
|
|
}
|
|
|
|
static struct value *
|
|
value_of_builtin_frame_sp_reg (const frame_info_ptr &frame, const void *baton)
|
|
{
|
|
struct gdbarch *gdbarch = get_frame_arch (frame);
|
|
|
|
if (gdbarch_sp_regnum (gdbarch) >= 0)
|
|
return value_of_register (gdbarch_sp_regnum (gdbarch),
|
|
get_next_frame_sentinel_okay (frame));
|
|
error (_("Standard register ``$sp'' is not available for this target"));
|
|
}
|
|
|
|
static struct value *
|
|
value_of_builtin_frame_ps_reg (const frame_info_ptr &frame, const void *baton)
|
|
{
|
|
struct gdbarch *gdbarch = get_frame_arch (frame);
|
|
|
|
if (gdbarch_ps_regnum (gdbarch) >= 0)
|
|
return value_of_register (gdbarch_ps_regnum (gdbarch),
|
|
get_next_frame_sentinel_okay (frame));
|
|
error (_("Standard register ``$ps'' is not available for this target"));
|
|
}
|
|
|
|
void _initialize_frame_reg ();
|
|
void
|
|
_initialize_frame_reg ()
|
|
{
|
|
/* Frame based $fp, $pc, $sp and $ps. These only come into play
|
|
when the target does not define its own version of these
|
|
registers. */
|
|
user_reg_add_builtin ("fp", value_of_builtin_frame_fp_reg, NULL);
|
|
user_reg_add_builtin ("pc", value_of_builtin_frame_pc_reg, NULL);
|
|
user_reg_add_builtin ("sp", value_of_builtin_frame_sp_reg, NULL);
|
|
user_reg_add_builtin ("ps", value_of_builtin_frame_ps_reg, NULL);
|
|
}
|