mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-12-05 23:23:09 +00:00
d159d87072
The documentation for gdb.register_window_type says:
"... It's an error to try to replace one of the built-in windows,
but other window types can be replaced. ..."
I take this to mean that if I imported a Python script like this:
gdb.register_window_type('my_window', FactoryFunction)
Then GDB would have a new TUI window 'my_window', which could be
created by calling FactoryFunction(). If I then, in the same GDB
session imported a script which included:
gdb.register_window_type('my_window', UpdatedFactoryFunction)
Then GDB would replace the old 'my_window' factory with my new one,
GDB would now call UpdatedFactoryFunction().
This is pretty useful in practice, as it allows users to iterate on
their window implementation within a single GDB session.
However, right now, this is not how GDB operates. The second call to
register_window_type is basically ignored and the old window factory
is retained.
This is because in tui_register_window (tui/tui-layout.c) we use
std::unordered_map::emplace to insert the new factory function, and
emplace doesn't replace an existing element in an unordered_map.
In this commit, before the emplace call, I now search for an already
existing element, and delete any matching element from the map, the
emplace call will then add the new factory function.
Reviewed-By: Tom Tromey <tom@tromey.com>
49 lines
1.5 KiB
Python
49 lines
1.5 KiB
Python
# Copyright (C) 2023 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
|
class TestWindow:
|
|
def __init__(self, tui_win, msg):
|
|
self.msg = msg
|
|
self.tui_win = tui_win
|
|
print("Entering TestWindow.__init__: %s" % self.msg)
|
|
|
|
def render(self):
|
|
self.tui_win.erase()
|
|
self.tui_win.write("TestWindow (%s)" % self.msg)
|
|
|
|
def __del__(self):
|
|
print("Entering TestWindow.__del__: %s" % self.msg)
|
|
|
|
|
|
class TestWindowFactory:
|
|
def __init__(self, msg):
|
|
self.msg = msg
|
|
print("Entering TestWindowFactory.__init__: %s" % self.msg)
|
|
|
|
def __call__(self, tui_win):
|
|
print("Entering TestWindowFactory.__call__: %s" % self.msg)
|
|
return TestWindow(tui_win, self.msg)
|
|
|
|
def __del__(self):
|
|
print("Entering TestWindowFactory.__del__: %s" % self.msg)
|
|
|
|
|
|
def register_window_factory(msg):
|
|
gdb.register_window_type("test_window", TestWindowFactory(msg))
|
|
|
|
|
|
print("Python script imported")
|