Files
binutils-gdb/gdb/arch/x86-linux-tdesc-features.c
Christina Schimpe 63b862be76 gdb, gdbserver: Add support of Intel shadow stack pointer register.
This patch adds the user mode register PL3_SSP which is part of the
Intel(R) Control-Flow Enforcement Technology (CET) feature for support
of shadow stack.
For now, only native and remote debugging support for shadow stack
userspace on amd64 linux are covered by this patch including 64 bit and
x32 support.  32 bit support is not covered due to missing Linux kernel
support.

This patch requires fixing the test gdb.base/inline-frame-cycle-unwind
which is failing in case the shadow stack pointer is unavailable.
Such a state is possible if shadow stack is disabled for the current thread
but supported by HW.

This test uses the Python unwinder inline-frame-cycle-unwind.py which fakes
the cyclic stack cycle by reading the pending frame's registers and adding
them to the unwinder:

~~~
for reg in pending_frame.architecture().registers("general"):
     val = pending_frame.read_register(reg)
     unwinder.add_saved_register(reg, val)
     return unwinder
~~~

However, in case the python unwinder is used we add a register (pl3_ssp) that is
unavailable.  This leads to a NOT_AVAILABLE_ERROR caught in
gdb/frame-unwind.c:frame_unwind_try_unwinder and it is continued with standard
unwinders.  This destroys the faked cyclic behavior and the stack is
further unwinded after frame 5.

In the working scenario an error should be triggered:
~~~
bt
0  inline_func () at /tmp/gdb.base/inline-frame-cycle-unwind.c:49^M
1  normal_func () at /tmp/gdb.base/inline-frame-cycle-unwind.c:32^M
2  0x000055555555516e in inline_func () at /tmp/gdb.base/inline-frame-cycle-unwind.c:45^M
3  normal_func () at /tmp/gdb.base/inline-frame-cycle-unwind.c:32^M
4  0x000055555555516e in inline_func () at /tmp/gdb.base/inline-frame-cycle-unwind.c:45^M
5  normal_func () at /tmp/gdb.base/inline-frame-cycle-unwind.c:32^M
Backtrace stopped: previous frame identical to this frame (corrupt stack?)
(gdb) PASS: gdb.base/inline-frame-cycle-unwind.exp: cycle at level 5: backtrace when the unwind is broken at frame 5
~~~

To fix the Python unwinder, we simply skip the unavailable registers.

Also it makes the test gdb.dap/scopes.exp fail.  The shadow stack feature is
disabled by default, so the pl3_ssp register which is added with my CET
shadow stack series will be shown as unavailable and we see a TCL error:
~~
>>> {"seq": 12, "type": "request", "command": "variables", "arguments": {"variablesReference": 2, "count": 85}}
Content-Length: 129^M
^M
{"request_seq": 12, "type": "response", "command": "variables", "success": false, "message": "value is not available", "seq": 25}FAIL: gdb.dap/scopes.exp: fetch all registers success
ERROR: tcl error sourcing /tmp/gdb/testsuite/gdb.dap/scopes.exp.
ERROR: tcl error code TCL LOOKUP DICT body
ERROR: key "body" not known in dictionary
    while executing
"dict get $val body variables"
    (file "/tmp/gdb/testsuite/gdb.dap/scopes.exp" line 152)
    invoked from within
"source /tmp/gdb/testsuite/gdb.dap/scopes.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source /tmp/gdb/testsuite/gdb.dap/scopes.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name" msg"
UNRESOLVED: gdb.dap/scopes.exp: testcase '/tmp/gdb/testsuite/gdb.dap/scopes.exp' aborted due to Tcl error
~~

I am fixing this by enabling the test for CET shadow stack, in case we
detect that the HW supports it:
~~~
    # If x86 shadow stack is supported we need to configure GLIBC_TUNABLES
    # such that the feature is enabled and the register pl3_ssp is
    # available.  Otherwise the reqeust to fetch all registers will fail
    # with "message": "value is not available".
    if { [allow_ssp_tests] } {
	append_environment GLIBC_TUNABLES "glibc.cpu.hwcaps" "SHSTK"
    }
~~~

Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
Approved-By: Luis Machado <luis.machado@arm.com>
Approved-By: Andrew Burgess <aburgess@redhat.com>
2025-08-29 17:02:09 +00:00

271 lines
7.3 KiB
C

/* Target description related code for GNU/Linux x86 (i386 and x86-64).
Copyright (C) 2024-2025 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "arch/x86-linux-tdesc-features.h"
/* A structure used to describe a single xstate feature bit that might, or
might not, be checked for when creating a target description for one of
i386, amd64, or x32.
The different CPU/ABI types check for different xstate features when
creating a target description.
We want to cache target descriptions, and this is currently done in
three separate caches, one each for i386, amd64, and x32. Additionally,
the caching we're discussing here is Linux only. Currently for Linux,
the only thing that has an impact on target description creation are
the supported features in xsave which are modelled by a xstate_bv
value, which has the same format than the state component bitmap.
In order to ensure the cache functions correctly we need to filter only
those xstate_bv feature bits that are relevant, we can then cache
target descriptions based on the relevant feature bits. Two xstate_bv
values might be different, but have the same relevant feature bits. In
this case we would expect the two xstate_bv values to map to the same
cache entry. */
struct x86_xstate_feature {
/* The xstate feature mask. This is a mask against the state component
bitmap. */
uint64_t feature;
/* Is this feature checked when creating an i386 target description. */
bool is_i386;
/* Is this feature checked when creating an amd64 target description. */
bool is_amd64;
/* Is this feature checked when creating an x32 target description. */
bool is_x32;
};
/* A constant table that describes all of the xstate features that are
checked when building a target description for i386, amd64, or x32.
If in the future, due to simplifications or refactoring, this table ever
ends up with 'true' for every xsave feature on every target type, then
this is an indication that this table should probably be removed, and
that the rest of the code in this file can be simplified. */
static constexpr x86_xstate_feature x86_linux_all_xstate_features[] = {
/* Feature, i386, amd64, x32. */
{ X86_XSTATE_CET_U, false, true, true },
{ X86_XSTATE_PKRU, true, true, true },
{ X86_XSTATE_AVX512, true, true, true },
{ X86_XSTATE_AVX, true, true, true },
{ X86_XSTATE_SSE, true, false, false },
{ X86_XSTATE_X87, true, false, false }
};
/* Return a compile time constant which is a mask of all the xstate features
that are checked for when building an i386 target description. */
static constexpr uint64_t
x86_linux_i386_xstate_bv_feature_mask_1 ()
{
uint64_t mask = 0;
for (const auto &entry : x86_linux_all_xstate_features)
if (entry.is_i386)
mask |= entry.feature;
return mask;
}
/* Return a compile time constant which is a mask of all the xstate features
that are checked for when building an amd64 target description. */
static constexpr uint64_t
x86_linux_amd64_xstate_bv_feature_mask_1 ()
{
uint64_t mask = 0;
for (const auto &entry : x86_linux_all_xstate_features)
if (entry.is_amd64)
mask |= entry.feature;
return mask;
}
/* Return a compile time constant which is a mask of all the xstate features
that are checked for when building an x32 target description. */
static constexpr uint64_t
x86_linux_x32_xstate_bv_feature_mask_1 ()
{
uint64_t mask = 0;
for (const auto &entry : x86_linux_all_xstate_features)
if (entry.is_x32)
mask |= entry.feature;
return mask;
}
/* See arch/x86-linux-tdesc-features.h. */
uint64_t
x86_linux_i386_xstate_bv_feature_mask ()
{
return x86_linux_i386_xstate_bv_feature_mask_1 ();
}
/* See arch/x86-linux-tdesc-features.h. */
uint64_t
x86_linux_amd64_xstate_bv_feature_mask ()
{
return x86_linux_amd64_xstate_bv_feature_mask_1 ();
}
/* See arch/x86-linux-tdesc-features.h. */
uint64_t
x86_linux_x32_xstate_bv_feature_mask ()
{
return x86_linux_x32_xstate_bv_feature_mask_1 ();
}
#ifdef GDBSERVER
/* See arch/x86-linux-tdesc-features.h. */
int
x86_linux_xstate_bv_to_tdesc_idx (uint64_t xstate_bv)
{
/* The following table shows which features are checked for when creating
the target descriptions (see nat/x86-linux-tdesc.c), the feature order
represents the bit order within the generated index number.
i386 | x87 sse avx avx512 pkru
amd64 | avx avx512 pkru
i32 | avx avx512 pkru
The features are ordered so that for each mode (i386, amd64, i32) the
generated index will form a continuous range. */
int idx = 0;
for (int i = 0; i < ARRAY_SIZE (x86_linux_all_xstate_features); ++i)
{
if ((xstate_bv & x86_linux_all_xstate_features[i].feature)
== x86_linux_all_xstate_features[i].feature)
idx |= (1 << i);
}
return idx;
}
#endif /* GDBSERVER */
#ifdef IN_PROCESS_AGENT
/* Return a compile time constant which is a count of the number of xstate
features that are checked for when building an i386 target description. */
static constexpr int
x86_linux_i386_tdesc_count_1 ()
{
uint64_t count = 0;
for (const auto &entry : x86_linux_all_xstate_features)
if (entry.is_i386)
++count;
gdb_assert (count > 0);
return (1 << count);
}
/* Return a compile time constant which is a count of the number of xstate
features that are checked for when building an amd64 target description. */
static constexpr int
x86_linux_amd64_tdesc_count_1 ()
{
uint64_t count = 0;
for (const auto &entry : x86_linux_all_xstate_features)
if (entry.is_amd64)
++count;
gdb_assert (count > 0);
return (1 << count);
}
/* Return a compile time constant which is a count of the number of xstate
features that are checked for when building an x32 target description. */
static constexpr int
x86_linux_x32_tdesc_count_1 ()
{
uint64_t count = 0;
for (const auto &entry : x86_linux_all_xstate_features)
if (entry.is_x32)
++count;
gdb_assert (count > 0);
return (1 << count);
}
/* See arch/x86-linux-tdesc-features.h. */
int
x86_linux_amd64_tdesc_count ()
{
return x86_linux_amd64_tdesc_count_1 ();
}
/* See arch/x86-linux-tdesc-features.h. */
int
x86_linux_x32_tdesc_count ()
{
return x86_linux_x32_tdesc_count_1 ();
}
/* See arch/x86-linux-tdesc-features.h. */
int
x86_linux_i386_tdesc_count ()
{
return x86_linux_i386_tdesc_count_1 ();
}
/* See arch/x86-linux-tdesc-features.h. */
uint64_t
x86_linux_tdesc_idx_to_xstate_bv (int idx)
{
uint64_t xstate_bv = 0;
for (int i = 0; i < ARRAY_SIZE (x86_linux_all_xstate_features); ++i)
{
if ((idx & (1 << i)) != 0)
xstate_bv |= x86_linux_all_xstate_features[i].feature;
}
return xstate_bv;
}
#endif /* IN_PROCESS_AGENT */